Merged
Conversation
Fryguy
approved these changes
Dec 3, 2025
miq-bot
force-pushed
the
update_english_translations
branch
2 times, most recently
from
f687576 to
a1be40d
Compare
miq-bot
force-pushed
the
update_english_translations
branch
from
a1be40d to
ce100b7
Compare
miq-bot
force-pushed
the
update_english_translations
branch
from
ce100b7 to
00e8965
Compare
miq-bot
force-pushed
the
update_english_translations
branch
2 times, most recently
from
39d36b5 to
d9300f0
Compare
miq-bot
force-pushed
the
update_english_translations
branch
from
d9300f0 to
df925d6
Compare
miq-bot
force-pushed
the
update_english_translations
branch
from
df925d6 to
9b5e7f5
Compare
jrafanie
added a commit
to jrafanie/manageiq-providers-proxmox
that referenced
this pull request
Mar 2, 2026
Note, this is fairly inconsistent across providers but when we see inconsistences, we should try to pick which way to go and since most providers have an incomplete sentence in these validation and helper texts, it makes sense to try to keep this non-sentence structure. I was noticing the english message catalog had the same partial sentence with and without the period: ``` msgid "Must start with a letter and contain only letters, numbers, and underscores" msgstr "" msgid "Must start with a letter and contain only letters, numbers, and underscores." msgstr "" ``` See: ManageIQ/manageiq#23665
miq-bot
force-pushed
the
update_english_translations
branch
from
9b5e7f5 to
cabc07a
Compare
Member
Author
|
Checked commit miq-bot@cabc07a with ruby 3.3.10, rubocop 1.56.3, haml-lint 0.69.0, and yamllint |
jrafanie
approved these changes
Mar 2, 2026
Member
jrafanie
left a comment
jrafanie
left a comment
There was a problem hiding this comment.
LGTM, just waiting on 💚 ci status
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Mar 4, 2026
English was merged in ManageIQ#23665
This was referenced Mar 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the English Translations in the manageiq.po and manageiq.pot files.