Skip to content

Removed Redundant Fatigue Check in Facility Report Update #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

IllianiBird
Copy link
Collaborator

  • Removed the campaignOptions.isUseFatigue() condition before updating the facility report label.
  • This ensures the facility report is always updated regardless of fatigue settings.

Fix #6526

Dev Notes

This conditional dates back to when Field Kitchens were the only facility we tracked.

- Removed the `campaignOptions.isUseFatigue()` condition before updating the facility report label.
- This ensures the facility report is always updated regardless of fatigue settings.
@IllianiBird IllianiBird added Bug GUI Severity: Low Issues described as low severity as per the new issue form labels Apr 1, 2025
@IllianiBird IllianiBird self-assigned this Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.28%. Comparing base (0496d05) to head (f6ae7a6).
Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6530   +/-   ##
=========================================
  Coverage     11.28%   11.28%           
+ Complexity     6321     6320    -1     
=========================================
  Files          1080     1080           
  Lines        137543   137541    -2     
  Branches      21300    21295    -5     
=========================================
+ Hits          15517    15519    +2     
+ Misses       120473   120467    -6     
- Partials       1553     1555    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rjhancock rjhancock merged commit 2c8d478 into MegaMek:master Apr 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GUI Severity: Low Issues described as low severity as per the new issue form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue][0.50.04] display of number of prisoners in the command center is not updated in some cases
2 participants