Fix #6545: Prevented Self-Crewed Unit Crew from Going on Maternity Leave Mid-Refit, Mid-Repair, or Mid-Mothballing #6582
+79
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it, Mid-Repair, or Mid-Mothballing - Replaced `isActive` check with the new `isBusy` method in maternity leave eligibility logic. - Added `isBusy` method in `Person` class to determine personnel activity based on status, unit assignments, and tasks. - Includes checks for self-crewed units, technicians, unit deployments, and various task states (mothballing, refitting, repairing).
IllianiCBT
added
Bug
Parts/Repair/Refit
Personnel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6582 +/- ##
=========================================
Coverage 11.43% 11.43%
- Complexity 6451 6454 +3
=========================================
Files 1087 1087
Lines 139447 139475 +28
Branches 21560 21575 +15
=========================================
+ Hits 15944 15952 +8
- Misses 121908 121927 +19
- Partials 1595 1596 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… the `isBusy` method in `Person.java`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isActivecheck with the newisBusymethod in maternity leave eligibility logic.isBusymethod inPersonclass to determine personnel activity based on status, unit assignments, and tasks.Fix #6545