Skip to content

Reduce Favorites in factory_sim #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
L4co77 merged 2 commits into from
Jan 6, 2026
Merged

Reduce Favorites in factory_sim #462

L4co77 merged 2 commits into from
Jan 6, 2026

Conversation

@L4co77
Copy link

@L4co77 L4co77 commented Jan 5, 2026

Screenshot from 2026-01-05 23-31-01

@L4co77 L4co77 added this to the 8.9.1 milestone Jan 5, 2026
@L4co77 L4co77 requested a review from griswaldbrooks January 5, 2026 22:33
@L4co77 L4co77 self-assigned this Jan 5, 2026
@L4co77
Copy link
Author

L4co77 commented Jan 6, 2026

@griswaldbrooks do you have any idea why the CI is failing?

@griswaldbrooks
Copy link

griswaldbrooks commented Jan 6, 2026

Have you pulled and rebased on the latest example_ws? Because that objective is skipped on main https://github.com/PickNikRobotics/moveit_pro_example_ws/blob/main/src/lab_sim/test/objectives_integration_test.py#L79

@L4co77 L4co77 enabled auto-merge January 6, 2026 17:46
@L4co77 L4co77 merged commit 333be02 into main Jan 6, 2026
5 checks passed
@noah-wardlow noah-wardlow removed this from the 8.9.1 milestone Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@griswaldbrooks griswaldbrooks griswaldbrooks approved these changes

Assignees

@L4co77 L4co77

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@L4co77 @griswaldbrooks @noah-wardlow