-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): Enjoy the benefits of /decide?v=4
. $feature_flag_called
events contain more details such as flag version
#1838
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR updates the PostHog JS library to use /decide?v=4
endpoint instead of /decide?v=3
, enabling enhanced debugging capabilities for feature flag events.
- Updates test assertions in
src/__tests__/posthog-core.loaded.test.ts
to expect/decide/?v=4
endpoint calls - Modifies network recording tests in
playwright/session-recording/session-recording-network-recorder.spec.ts
to validate v4 endpoint patterns - Adds support for additional metadata in feature flag events including flag versions, IDs, and evaluation reasons
- Maintains backwards compatibility while providing more detailed debugging information in
$feature_flag_called
events - Follows up on PR feat(flags): Support
/decide?v=4
and include version info flag called events #1837 which added initial v4 support but kept using v3 endpoint
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Size Change: +22.5 kB (+0.62%) Total Size: 3.63 MB
ℹ️ View Unchanged
|
This is a follow-up to #1837 where we added support for `/decide?v=4` in a backwards compatible fashion, but still made requests to `/decide?v=3` With this change, we should get more useful debug information in `$feature_flag_called` events.
a1c5b42
to
1c4318f
Compare
/decide?v=4
/decide?v=4
. $feature_flag_called
events will contain more details such as flag version
/decide?v=4
. $feature_flag_called
events will contain more details such as flag version/decide?v=4
. $feature_flag_called
events contain more details such as flag version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good; CI looks annoyed. LMK if you want to untangle CI together!
This reverts commit 4c25512.
This reverts commit 4c25512.
This is a follow-up to #1837 where we added support for
/decide?v=4
in a backwards compatible fashion, but still made requests to/decide?v=3
With this change, we should get more useful debug information in
$feature_flag_called
events.Changes
Changes the library to request
/decide?v=4
instead of/decide?v=3
. All the substantial changes were made in #1837.Checklist