SAT-20386 Jira card is closed; removing it.

[amolpati30]

The host is enabled with FIPS mode, so card SAT-20386 is being removed as the condition is no longer required.

Summary by Sourcery

Adjust RHEL PXE FIPS provisioning test expectations and skipping behavior for specific firmware/OS combinations.

Tests:

• Add a conditional skip for the RHEL PXE FIPS provisioning test when running on RHEL 7 with UEFI firmware under an open SAT-41340.
• Update the FIPS-enabled assertion in the RHEL PXE provisioning test to always require FIPS to be enabled, removing the SAT-20386 conditional.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the RHEL PXE FIPS provisioning test to always require FIPS to be enabled post-provisioning and adds a conditional skip for unsupported UEFI RHEL7 scenarios tied to an open Jira issue.

File-Level Changes

Change	Details	Files
Add conditional skip for unsupported RHEL7 UEFI firmware scenario in the FIPS-enabled provisioning test.	Introduce a check for Jira SAT-41340 being open combined with UEFI firmware and RHEL 7 OS major version. Call pytest.skip with a clear message when the combination of conditions indicates the test is not supported.	tests/foreman/api/test_provisioning.py
Tighten FIPS assertion to always require FIPS to be enabled on provisioned hosts.	Remove conditional logic based on Jira SAT-20386 when asserting /proc/sys/crypto/fips_enabled. Assert that the FIPS flag read from the host is always 1 after provisioning.	tests/foreman/api/test_provisioning.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• When asserting on result.stdout, consider converting result.stdout.strip() to int to avoid potential failures due to trailing newlines or spaces in the command output.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- When asserting on `result.stdout`, consider converting `result.stdout.strip()` to `int` to avoid potential failures due to trailing newlines or spaces in the command output.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Satellite-QE]

PRT Result

Build Number: 14413
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : =========== 1 failed, 7 passed, 564 warnings in 11850.32s (3:17:30) ============

[amolpati30]

RHEL 7 does not support UEFI refer - SAT-41340, so one failure is expected.

[vijaysawant]

Ack

[sourcery-ai]

Hey - I've left some high level feedback:

• The new skip block says it applies to 'UEFI and SecureBoot loaders' but the condition only checks pxe_loader.vm_firmware in ['uefi']; if SecureBoot is represented differently than plain uefi you may want to either broaden the condition or clarify the comment to match the actual behavior.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new skip block says it applies to 'UEFI and SecureBoot loaders' but the condition only checks `pxe_loader.vm_firmware in ['uefi']`; if SecureBoot is represented differently than plain `uefi` you may want to either broaden the condition or clarify the comment to match the actual behavior.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Satellite-QE]

PRT Result

Build Number: 14427
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : =========== 1 failed, 7 passed, 541 warnings in 12147.62s (3:22:27) ============

[Satellite-QE]

PRT Result

Build Number: 14440
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : ====== 1 failed, 6 passed, 1 skipped, 553 warnings in 11826.29s (3:17:06) ======

[Satellite-QE]

PRT Result

Build Number: 14447
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : ====== 2 failed, 5 passed, 1 skipped, 564 warnings in 12826.93s (3:33:46) ======

[Satellite-QE]

PRT Result

Build Number: 14460
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : ======= 1 failed, 5 passed, 479 warnings, 2 errors in 9952.38s (2:45:52) =======

[Satellite-QE]

PRT Result

Build Number: 14516
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : =========== 2 failed, 6 passed, 556 warnings in 13945.95s (3:52:25) ============

[Satellite-QE]

PRT Result

Build Number: 14530
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : ====== 2 failed, 4 passed, 575 warnings, 2 errors in 24751.21s (6:52:31) =======

[amolpati30]

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled
provisioning: true

[Satellite-QE]

PRT Result

Build Number: 14547
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : =========== 7 passed, 1 skipped, 559 warnings in 10470.36s (2:54:30) ===========

[nacoool]

LGTM.