Check payload state in gpio_controller (backport #1770)#1777
Open
mergify[bot] wants to merge 1 commit intokiltedfrom
Open
Check payload state in gpio_controller (backport #1770)#1777mergify[bot] wants to merge 1 commit intokiltedfrom
mergify[bot] wants to merge 1 commit intokiltedfrom
Conversation
Before, we were returning success, as soon as the hardware interface attempted to setup the payload. This change reads the payload information from the robot and only returns success if the read payload matches with what the user requested. This is active by default, but will be inactive when using mock hardware. Add tests verifying setPayload works with URSim and mock hardware (cherry picked from commit fbf5704) # Conflicts: # ur_robot_driver/launch/ur_control.launch.py
Author
|
Cherry-pick of fbf5704 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we were returning success, as soon as the hardware interface attempted to setup the payload.
This change reads the payload information from the robot and only returns success if the read payload matches with what the user requested.
Note: This kind of check should probably done for other services, as well. I didn't do it so far, since there are so many other things I would like to change in this controller (mainly the thread-synchronization issues and splitting up functionalities).
This is an automatic backport of pull request #1770 done by Mergify.