fix(agnocastlib): fix error handling in executor

[Koichi98]

Description

Related links

How was this PR tested?

• Autoware (required)
• bash scripts/test/e2e_test_1to1 (required)
• bash scripts/test/e2e_test_2to2 (required)
• kunit tests (required when modifying the kernel module)
• sample application

Notes for reviewers

Version Update Label (Required)

Please add exactly one of the following labels to this PR:

• need-major-update: User API breaking changes
• need-minor-update: Internal API breaking changes (heaphook/kmod/agnocastlib compatibility)
• need-patch-update: Bug fixes and other changes

Important notes:

• If you need need-major-update or need-minor-update, please include this in the PR title as well.
  • Example: fix(foo)[needs major version update]: bar or feat(baz)[needs minor version update]: qux
• After receiving approval from reviewers, add the run-build-test label. The PR can only be merged after the build tests pass.

See CONTRIBUTING.md for detailed versioning rules.

[Copilot]

Pull request overview

This PR updates agnocastlib’s executor/signal/epoll error handling to avoid exit(EXIT_FAILURE) and instead surface failures via C++ exceptions, enabling callers to decide how to handle fatal vs. recoverable errors.

Changes:

• Replace RCLCPP_ERROR + exit() (and associated close() calls) with std::runtime_error / std::logic_error / std::invalid_argument across executors and epoll helpers.
• Propagate epoll/signal installation failures via exceptions, and standardize error messages for these failures.
• Keep multi-threaded executors resilient by catching exceptions in worker threads and rethrowing a summarized failure in the caller thread.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/agnocastlib/src/node/agnocast_signal_handler.cpp	Switch SIGINT/SIGTERM installation failures from process-exit to throwing exceptions.
src/agnocastlib/src/node/agnocast_only_single_threaded_executor.cpp	Throw on illegal re-entrant spin() instead of exiting.
src/agnocastlib/src/node/agnocast_only_multi_threaded_executor.cpp	Throw on illegal re-entrant spin(), keep worker-thread exception handling.
src/agnocastlib/src/node/agnocast_only_executor.cpp	Convert constructor and node/group association fatal paths to exceptions.
src/agnocastlib/src/node/agnocast_only_callback_isolated_executor.cpp	Convert fatal add-node/spin guard paths to exceptions.
src/agnocastlib/src/agnocast_single_threaded_executor.cpp	Convert nullptr callback group + double-spin fatal paths to exceptions.
src/agnocastlib/src/agnocast_multi_threaded_executor.cpp	Convert validation + double-spin fatal paths to exceptions; keep worker-thread catch/flagging.
src/agnocastlib/src/agnocast_executor.cpp	Throw on epoll_create1 failure instead of exiting.
src/agnocastlib/src/agnocast_epoll.cpp	Throw on epoll/mq_receive/internal-map errors instead of exiting.
src/agnocastlib/src/agnocast_callback_isolated_executor.cpp	Convert double-spin and duplicate add/remove error paths to exceptions.
src/agnocastlib/include/agnocast/agnocast_epoll.hpp	Convert epoll registration failures in prepare_epoll_impl to exceptions.

Comments suppressed due to low confidence (1)

src/agnocastlib/src/node/agnocast_only_executor.cpp:47

• AgnocastOnlyExecutor now throws on failures, and SignalHandler::install() can also throw. If install()/register_shutdown_event() throws here, the constructor will unwind and the destructor will not run, leaking epoll_fd_ and shutdown_event_fd_ (and leaving shutdown_event_fd_ registered if registration happened). Wrap the SignalHandler calls in a try/catch that closes/unregisters the fds before rethrowing, or use RAII wrappers for these fds during construction.

  if (epoll_ctl(epoll_fd_, EPOLL_CTL_ADD, shutdown_event_fd_, &ev) == -1) {
    close(shutdown_event_fd_);
    close(epoll_fd_);
    throw std::runtime_error(
      std::string("epoll_ctl for shutdown_event_fd failed: ") + strerror(errno));
  }

  SignalHandler::install();
  SignalHandler::register_shutdown_event(shutdown_event_fd_);
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.