ci: gate setup-universe behind run:health-check, unify label reusable#7029
Merged
ci: gate setup-universe behind run:health-check, unify label reusable#7029
Conversation
- Put setup-universe behind the same `run:health-check` label the docker-new health-check workflow uses. setup-universe runs the setup-dev-env.sh script on a self-hosted runner, so triggering it on every PR is expensive; a single label now toggles both heavyweight pre-merge checks together. - Switch health-check from `make-sure-label-is-present.yaml@v1` to `require-label.yaml@v1`, matching the sub-repo build-and-test workflows and the new setup-universe gate. Also drops an unused `load: false` in the bake step (false is the default). Signed-off-by: Mete Fatih Cırıt <[email protected]>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup-universebehind therun:health-checklabel: add arequire-labeljob plusneeds:/if:on the existingsetup-universejob, and addpull_request.types(opened,synchronize,reopened,labeled) so the workflow re-triggers when the label is added mid-review.health-check.yamlfrommake-sure-label-is-present.yaml@v1torequire-label.yaml@v1(job renamedlabel-check→require-label).Why
setup-universerunssetup-dev-env.shon a self-hosted runner and consumes meaningful time on every PR. It only needs to run for infrastructure-touching PRs — the same gatehealth-checkalready uses. A singlerun:health-checklabel now toggles both heavyweight pre-merge checks. Switching both callers torequire-label.yaml@v1aligns with the sub-repo build-and-test workflows and surfaces missing labels as red status rather than silent skips.Test plan
.github/workflows/setup-universe.yamlwithout therun:health-checklabel. Expect therequire-labeljob red andsetup-universeskipped.run:health-checklabel to that PR. Expectrequire-labelgreen andsetup-universeto proceed through toRun setup script.health-checkviascheduleorworkflow_dispatchwith no label. Expectrequire-labelskipped butdocker-buildstill running because theif:admitsschedule/workflow_dispatch.