Skip to content

ci: gate setup-universe behind run:health-check, unify label reusable#7029

Merged
xmfcx merged 1 commit intomainfrom
feat/split-02-setup-universe-label-gate
Apr 17, 2026
Merged

ci: gate setup-universe behind run:health-check, unify label reusable#7029
xmfcx merged 1 commit intomainfrom
feat/split-02-setup-universe-label-gate

Conversation

@xmfcx
Copy link
Copy Markdown
Contributor

@xmfcx xmfcx commented Apr 17, 2026

  • Parent Issue: Simplify the docker images and workflows #6852
  • Gate setup-universe behind the run:health-check label: add a require-label job plus needs: / if: on the existing setup-universe job, and add pull_request.types (opened, synchronize, reopened, labeled) so the workflow re-triggers when the label is added mid-review.
  • Switch health-check.yaml from make-sure-label-is-present.yaml@v1 to require-label.yaml@v1 (job renamed label-checkrequire-label).

Why

setup-universe runs setup-dev-env.sh on a self-hosted runner and consumes meaningful time on every PR. It only needs to run for infrastructure-touching PRs — the same gate health-check already uses. A single run:health-check label now toggles both heavyweight pre-merge checks. Switching both callers to require-label.yaml@v1 aligns with the sub-repo build-and-test workflows and surfaces missing labels as red status rather than silent skips.


Test plan

  • Open a PR touching .github/workflows/setup-universe.yaml without the run:health-check label. Expect the require-label job red and setup-universe skipped.
  • Add the run:health-check label to that PR. Expect require-label green and setup-universe to proceed through to Run setup script.
  • Trigger health-check via schedule or workflow_dispatch with no label. Expect require-label skipped but docker-build still running because the if: admits schedule/workflow_dispatch.

- Put setup-universe behind the same `run:health-check` label the
  docker-new health-check workflow uses. setup-universe runs the
  setup-dev-env.sh script on a self-hosted runner, so triggering it on
  every PR is expensive; a single label now toggles both heavyweight
  pre-merge checks together.
- Switch health-check from `make-sure-label-is-present.yaml@v1` to
  `require-label.yaml@v1`, matching the sub-repo build-and-test
  workflows and the new setup-universe gate.

Also drops an unused `load: false` in the bake step (false is the
default).

Signed-off-by: Mete Fatih Cırıt <[email protected]>
@xmfcx xmfcx self-assigned this Apr 17, 2026
@github-actions
Copy link
Copy Markdown

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Copy Markdown
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xmfcx xmfcx enabled auto-merge (squash) April 17, 2026 16:20
@xmfcx xmfcx disabled auto-merge April 17, 2026 17:11
@xmfcx xmfcx merged commit 3ff681a into main Apr 17, 2026
20 of 24 checks passed
@xmfcx xmfcx deleted the feat/split-02-setup-universe-label-gate branch April 17, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants