feat(ansible): add install_docker.yaml and deprecate docker.yaml#7057
Merged
feat(ansible): add install_docker.yaml and deprecate docker.yaml#7057
Conversation
Phase 1 (additive) of the ansible-entrypoint consolidation tracked in #7052. - Adds `install_docker.yaml`: tag-driven playbook installing docker_engine and nvidia_container_toolkit. No host-side CUDA since CUDA userspace libs belong inside the container. - Marks `docker.yaml` with a deprecation banner pointing to the replacement and a removal date of 2026-05-24. File is otherwise untouched and remains functional during the transition window so external consumers (TIER IV internal scripts, openadkit) can migrate. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
xmfcx
requested review from
isamu-takagi,
mitsudome-r,
oguzkaganozt and
youtalk
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ansible/playbooks/install_docker.yaml: tag-driven playbook installingdocker_engine+nvidia_container_toolkit. No host-side CUDA since CUDA userspace libs belong inside the container.ansible/playbooks/docker.yamlwith a deprecation banner pointing to the replacement and a removal date of 2026-05-24. File is untouched otherwise and remains fully functional.Why
Phase 1 (additive only) of the ansible-entrypoint consolidation tracked in #7052. External consumers reference
docker.yaml(TIER IV internal scripts,autowarefoundation/openadkit), so it cannot be renamed or deleted in this PR. Landing the replacement + deprecation marker now gives consumers a ~1 month migration window before Phase 2 deletes the old file.New playbook follows the tag-driven convention already used by
autoware_requirements.yamlandinstall_dev_env.yaml: novars_prompt, all opt-in/opt-out via--tags/--skip-tags.Test plan
Lint passes:
New playbook installs Docker + NVIDIA container toolkit on a clean Ubuntu 24.04 host:
`--skip-tags nvidia` installs Docker only, no NVIDIA toolkit:
Old `docker.yaml` still runs end-to-end (backwards compatibility during the deprecation window):
Deprecation banner visible at the top of `ansible/playbooks/docker.yaml` on the PR diff view.