fix(autoware_cmake): remove workaround, fixed in https://github.com/ros2/tinyxml2_vendor/pull/23#30
Open
esteve wants to merge 1 commit intoautowarefoundation:mainfrom
Open
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Contributor
Author
|
Do not merge until ros2/tinyxml2_vendor#23 is merged and backported to Humble |
esteve
force-pushed
the
remove-tinxyml2-workaround
branch
from
a677624 to
87ea7ec
Compare
esteve
changed the title
esteve
force-pushed
the
remove-tinxyml2-workaround
branch
from
87ea7ec to
b0f1f4f
Compare
Contributor
Author
|
@mitsudome-r @youtalk ros2/tinyxml2_vendor#27 and ros2/tinyxml2_vendor#28 are now merged and released, this PR can now be merged |
3 tasks
mitsudome-r
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the workaround for autowarefoundation/autoware_universe#10410
How was this PR tested?
This was tested on an Ubuntu 22.04 container, with and without the workaround.
Notes for reviewers
None.
Effects on system behavior
None.