Skip to content

feat(lanelet2_extension): port lanelet2_extension utilities functions (final) #838

Merged
soblin merged 25 commits intoautowarefoundation:mainfrom
sarun-hub:feat/port_utilities_final
Feb 27, 2026
Merged

feat(lanelet2_extension): port lanelet2_extension utilities functions (final) #838
soblin merged 25 commits intoautowarefoundation:mainfrom
sarun-hub:feat/port_utilities_final

Conversation

@sarun-hub
Copy link
Copy Markdown
Contributor

@sarun-hub sarun-hub commented Feb 13, 2026

Description

Most functions in autoware_lanelet2_extension/utilities are ported in #621, #693, #704, and #760.
These are the last set of functions to be ported from utilities to autoware_lanelet2_utils.
Target Functions:

  • isInLanelet
  • getArcCoordinatesOnEgoCenterline
  • getPolygonFromArcLength
  • generateFineCenterline (NEW) -> get_fine_centerline

Reorder unit tests number ✅

Documentation (API Table and illustration ✅ , example code snippet ✅ )
Usage replacement in autoware_core

Related links

lanelet2_extension (deprecation): #103
autoware_universe (replacement): #12173
core #868 - function to create ConstLanelet from ConstLineString3d

Parent Issue:

  • Link

How was this PR tested?

Comomon
FuncVerification

Notes for reviewers

Currently CI will fail due to lanelet2_extension/utilities.hpp include removal in advance, required #842 to be merged to resolve. #842 is merged ✅

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
@sarun-hub sarun-hub self-assigned this Feb 13, 2026
@sarun-hub sarun-hub added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 13, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 13, 2026

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 46.42857% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.15%. Comparing base (2b119c9) to head (1900e27).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...oware_lanelet2_utils/examples/example_geometry.cpp 0.00% 39 Missing ⚠️
common/autoware_lanelet2_utils/src/geometry.cpp 80.00% 6 Missing and 5 partials ⚠️
...nning/autoware_route_handler/src/route_handler.cpp 0.00% 5 Missing and 1 partial ⚠️
...on_planner/src/mission_planner/mission_planner.cpp 0.00% 3 Missing ⚠️
planning/autoware_path_generator/src/utils.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   50.17%   50.15%   -0.03%     
==========================================
  Files         356      353       -3     
  Lines       22795    22883      +88     
  Branches    10102    10140      +38     
==========================================
+ Hits        11438    11477      +39     
- Misses      10257    10302      +45     
- Partials     1100     1104       +4     
Flag Coverage Δ *Carryforward flag
daily-humble 50.53% <ø> (+<0.01%) ⬆️ Carriedforward from 61157cf
daily-jazzy 50.01% <ø> (+<0.01%) ⬆️ Carriedforward from 61157cf
differential-humble 37.62% <46.42%> (?)
differential-jazzy 37.59% <45.87%> (?)
total 50.22% <ø> (+<0.01%) ⬆️ Carriedforward from 61157cf
total-humble 50.54% <ø> (-0.01%) ⬇️ Carriedforward from 61157cf
total-jazzy 50.02% <ø> (+<0.01%) ⬆️ Carriedforward from 61157cf

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
@sarun-hub
Copy link
Copy Markdown
Contributor Author

sarun-hub commented Feb 18, 2026

get_arc_coordinates_on_centerline (ported getArcCoodinatesOnCenterline) required test with waypoints attribute in ConstLanelet. Mark for now, will add soon.
Note: get_arc_coordinates_on_centerline can be changed to overload of get_arc_coordinates.

Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
@sarun-hub
Copy link
Copy Markdown
Contributor Author

commit a328a6c will be later separated to another PR for more dedicated PR. (it has different scope)

Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
@sarun-hub sarun-hub added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Feb 18, 2026
@github-actions
Copy link
Copy Markdown

Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
@sarun-hub sarun-hub force-pushed the feat/port_utilities_final branch from 1ddad79 to 505a58c Compare February 18, 2026 07:27
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
@sarun-hub
Copy link
Copy Markdown
Contributor Author

sarun-hub commented Feb 19, 2026

The commit 7d0d3e3
will cause failure due to lanelet2_extension/utilities include removal.

Waiting for #842 to be merged, to pass the build checks [SOLVED] ✅

sarun-hub and others added 2 commits February 19, 2026 15:23
Comment thread common/autoware_lanelet2_utils/src/geometry.cpp
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
@sarun-hub sarun-hub added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Feb 25, 2026
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
@soblin soblin merged commit 14bf5e7 into autowarefoundation:main Feb 27, 2026
39 of 43 checks passed
sarun-hub added a commit to sarun-hub/autoware_core that referenced this pull request Mar 5, 2026
… (final) (autowarefoundation#838)

Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants