feat(tier4_control_rviz_plugin): replace autoware_universe_utils with autoware_utils_rclcpp#408
Open
vish0012 wants to merge 1 commit intoautowarefoundation:mainfrom
Conversation
… autoware_utils_rclcpp Migrates InterProcessPollingSubscriber usage from autoware_universe_utils to the specific autoware_utils_rclcpp sub-package as part of the autoware_universe_utils deprecation tracked in autowarefoundation/autoware_universe#12376. Changes: - package.xml: autoware_universe_utils -> autoware_utils_rclcpp - src/tools/manual_controller.hpp: - #include <autoware/universe_utils/ros/polling_subscriber.hpp> -> #include <autoware_utils_rclcpp/polling_subscriber.hpp> - autoware::universe_utils::InterProcessPollingSubscriber -> autoware_utils_rclcpp::InterProcessPollingSubscriber - src/tools/manual_controller.cpp: - autoware::universe_utils::InterProcessPollingSubscriber -> autoware_utils_rclcpp::InterProcessPollingSubscriber - ->takeData() -> ->take_data() (camelCase to snake_case) Signed-off-by: github-actions <github-actions@github.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces
autoware_universe_utilsdependency in thetier4_control_rviz_pluginpackage with the specificautoware_utils_rclcppsub-package, following the minimum-dependency principle.Changes
common/tier4_control_rviz_plugin/package.xml<depend>autoware_universe_utils</depend>→<depend>autoware_utils_rclcpp</depend>common/tier4_control_rviz_plugin/src/tools/manual_controller.hpp#include <autoware/universe_utils/ros/polling_subscriber.hpp>→#include <autoware_utils_rclcpp/polling_subscriber.hpp>autoware::universe_utils::InterProcessPollingSubscriber→autoware_utils_rclcpp::InterProcessPollingSubscribercommon/tier4_control_rviz_plugin/src/tools/manual_controller.cppautoware::universe_utils::InterProcessPollingSubscriber→autoware_utils_rclcpp::InterProcessPollingSubscriber->takeData()→->take_data()(method renamed camelCase → snake_case in new class API)Related Issue
Part of the
autoware_universe_utilsdeprecation effort tracked in autowarefoundation/autoware_universe#12376 (theautoware_toolschecklist item).Additional notes
Part of a series of similar PRs for
autoware_tools, grouped by top-level directory: