feat(bvp): add detection lane module #10584
CodeScene PR Check
Quality Gate Failed
Gates Failed
(1 new file with code health below 9.00)
(2 files with Bumpy Road Ahead)
(3 files with Complex Method, Overall Code Complexity)
Gates Passed
See analysis details in CodeScene
Reason for failure
| New code is healthy | Violations | Code Health Impact | |
|---|---|---|---|
| scene.cpp | 3 rules | 10.00 → 8.69 | Suppress |
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| scene.cpp | 1 critical rule | 10.00 → 8.69 | Suppress |
| manager.cpp | 1 critical rule | 10.00 → 9.40 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| scene.cpp | 2 advisory rules | 10.00 → 8.69 | Suppress |
| manager.cpp | 1 advisory rule | 10.00 → 9.40 | Suppress |
| rtc_interface.cpp | 1 advisory rule | 7.70 → 7.67 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Overall Code Complexity scene.cpp
- Complex Method scene.cpp: DetectionLaneModule::modifyPathVelocity
- Complex Method manager.cpp: DetectionLaneModuleManager::launchNewModules
- Complex Method rtc_interface.cpp: getModuleType
- Bumpy Road Ahead scene.cpp: DetectionLaneModule::modifyPathVelocity
- Bumpy Road Ahead manager.cpp: DetectionLaneModuleManager::launchNewModules
- Bumpy Road Ahead scene.cpp: DetectionLaneModule::is_safe
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
DetectionLaneModuleManager::launchNewModules has a cyclomatic complexity of 16, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
DetectionLaneModuleManager::launchNewModules has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
DetectionLaneModule::modifyPathVelocity has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
DetectionLaneModule::modifyPathVelocity has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
DetectionLaneModule::is_safe has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Overall Code Complexity
This module has a mean cyclomatic complexity of 5.00 across 11 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check warning on line 73 in planning/autoware_rtc_interface/src/rtc_interface.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
getModuleType increases in cyclomatic complexity from 21 to 22, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.