refactor(raw vehicle cmd converter): removal of unnecessary variables and addition of private modifiers #11606
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Autumn60 <[email protected]>
Signed-off-by: Autumn60 <[email protected]>
Signed-off-by: Autumn60 <[email protected]>
github-actions
bot
added
the
component:vehicle
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Autumn60
added
the
run:build-and-test-differential
Autumn60
requested review from
TakaHoribe,
kosuke55,
kyoichi-sugahara,
mkuri,
taikitanaka3,
takayuki5168 and
zusizusi
as code owners
Autumn60
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11606 +/- ##
==========================================
+ Coverage 17.79% 17.95% +0.15%
==========================================
Files 1747 1742 -5
Lines 122072 121209 -863
Branches 42813 42748 -65
==========================================
+ Hits 21727 21766 +39
+ Misses 82137 81400 -737
+ Partials 18208 18043 -165
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removal of unused variables and addition of private modifiers.
Related links
None
How was this PR tested?
build-and-test CI result
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.