-
Notifications
You must be signed in to change notification settings - Fork 809
feat: system related packages support jazzy #11626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: system related packages support jazzy #11626
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
ea7fb46 to
090fda0
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11626 +/- ##
==========================================
+ Coverage 17.80% 18.10% +0.30%
==========================================
Files 1746 1757 +11
Lines 122013 122384 +371
Branches 42794 43279 +485
==========================================
+ Hits 21723 22158 +435
- Misses 82076 82444 +368
+ Partials 18214 17782 -432
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: liuXinGangChina <[email protected]>
090fda0 to
2652bf2
Compare
Description
Fixes compilation errors in system packages for ROS 2 Jazzy. Updates deprecated APIs, adds missing headers, and resolves library compatibility issues.
Changes
1.
autoware_default_adapi_universermw_qos_profile_services_defaultAPI usageAUTOWARE_DEFAULT_SERVICES_QOS_PROFILE()macro fromautoware_qos_utilspackagesrc/diagnostics.cpp: Added#include <autoware/qos_utils/qos_compatibility.hpp>and updated service client creationpackage.xml: Addedautoware_qos_utilsdependency2.
autoware_mrm_handlerrmw_qos_profile_services_defaultAPI usageAUTOWARE_DEFAULT_SERVICES_QOS_PROFILE()macro fromautoware_qos_utilspackagesrc/mrm_handler/mrm_handler_core.cpp: Added#include <autoware/qos_utils/qos_compatibility.hpp>and updated service client creationpackage.xml: Addedautoware_qos_utilsdependency3.
autoware_pipeline_latency_monitorcreate_generic_subscriptionconst std::shared_ptr<rclcpp::SerializedMessage> &tostd::shared_ptr<const rclcpp::SerializedMessage>src/pipeline_latency_monitor_node.cpp: Updated lambda callback parameter type4.
autoware_system_monitorIssue: Missing
rclcpp/rclcpp.hppheader includes in monitor classesFix: Added explicit
#include <rclcpp/rclcpp.hpp>to all monitor class headersFiles Modified:
include/system_monitor/hdd_monitor/hdd_monitor.hppinclude/system_monitor/mem_monitor/mem_monitor.hppinclude/system_monitor/gpu_monitor/gpu_monitor_base.hppinclude/system_monitor/voltage_monitor/voltage_monitor.hppinclude/system_monitor/ntp_monitor/ntp_monitor.hppinclude/system_monitor/net_monitor/net_monitor.hppIssue: Missing
<fstream>header includesFix: Added
#include <fstream>wherestd::ifstreamandstd::ofstreamare usedFiles Modified:
reader/traffic_reader/traffic_reader_service.cpptest/src/process_monitor/test_process_monitor.cpp5.
autoware_velodyne_monitorstd::bytecausing compilation errorsfmt::format()with standard string concatenationsrc/velodyne_monitor.cpp: Removed fmt includes and replacedfmt::format()withstd::to_string()+ string concatenationCMakeLists.txt: Removedfmtfromtarget_link_librariesRelated links
Parent Issue:
How was this PR tested?
ci: add jazzy docker build process in current ci pipeline autoware#6453
build command
`colcon build --cmake-args -DCMAKE_BUILD_TYPE=Release --symlink-install --packages-select <all-packages-in-autoware_universe/system>
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.