-
Notifications
You must be signed in to change notification settings - Fork 809
fix(diffusion planner): fix output z #11629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(diffusion planner): fix output z #11629
Conversation
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11629 +/- ##
==========================================
+ Coverage 17.84% 17.88% +0.04%
==========================================
Files 1744 1747 +3
Lines 121738 122007 +269
Branches 42774 42836 +62
==========================================
+ Hits 21721 21821 +100
- Misses 81812 82107 +295
+ Partials 18205 18079 -126
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR fixes the handling of Z-coordinate data in the diffusion planner by properly preserving Z-coordinates throughout the pipeline while maintaining compatibility with the neural network that expects 33-dimensional input without Z-coordinates.
Key Changes:
remove_z_coords()function to strip Z-coordinates for network input while preserving them for visualization and trajectory generationHow was this PR tested?
Before
The trajectory and markers are output at a height slightly above the lanelet. They are also significantly affected by roll and pitch.
before.mp4
After
The trajectory and markers are output at the same height as the lanelet. They are hardly affected by roll or pitch.
after.mp4
Notes for reviewers
This change may cause strange behavior in environments with overpasses.
1:45~
r_reduced_x2.mp4
Interface changes
None.
Effects on system behavior
None.