Skip to content

Conversation

@SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Nov 13, 2025

Description

This PR fixes the handling of Z-coordinate data in the diffusion planner by properly preserving Z-coordinates throughout the pipeline while maintaining compatibility with the neural network that expects 33-dimensional input without Z-coordinates.

Key Changes:

  • Added support for Z-coordinates (Z, dZ, LB_Z, RB_Z) in lane segment data, expanding from 33 to 37 dimensions
  • Implemented remove_z_coords() function to strip Z-coordinates for network input while preserving them for visualization and trajectory generation
  • Updated trajectory generation to use Z-coordinates from route lanes for accurate vertical positioning

How was this PR tested?

Before

The trajectory and markers are output at a height slightly above the lanelet. They are also significantly affected by roll and pitch.

before.mp4

After

The trajectory and markers are output at the same height as the lanelet. They are hardly affected by roll or pitch.

after.mp4

Notes for reviewers

This change may cause strange behavior in environments with overpasses.

1:45~

r_reduced_x2.mp4

Interface changes

None.

Effects on system behavior

None.

@SakodaShintaro SakodaShintaro self-assigned this Nov 13, 2025
@SakodaShintaro SakodaShintaro added component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

This comment was marked as resolved.

Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 13.15789% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.88%. Comparing base (ce43717) to head (1bf708e).

Files with missing lines Patch % Lines
...oware_diffusion_planner/src/utils/marker_utils.cpp 0.00% 29 Missing ⚠️
...fusion_planner/src/preprocessing/lane_segments.cpp 0.00% 13 Missing ⚠️
...e_diffusion_planner/src/diffusion_planner_node.cpp 0.00% 12 Missing ⚠️
...lanner/src/postprocessing/postprocessing_utils.cpp 45.00% 10 Missing and 1 partial ⚠️
..._planner/src/preprocessing/preprocessing_utils.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11629      +/-   ##
==========================================
+ Coverage   17.84%   17.88%   +0.04%     
==========================================
  Files        1744     1747       +3     
  Lines      121738   122007     +269     
  Branches    42774    42836      +62     
==========================================
+ Hits        21721    21821     +100     
- Misses      81812    82107     +295     
+ Partials    18205    18079     -126     
Flag Coverage Δ *Carryforward flag
daily 20.02% <ø> (ø) Carriedforward from ce43717
daily-cuda 17.82% <ø> (-0.02%) ⬇️ Carriedforward from ce43717
differential-cuda 14.52% <13.15%> (?)
total-cuda 17.82% <ø> (-0.02%) ⬇️ Carriedforward from ce43717

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant