Skip to content

Conversation

@Owen-Liuyuxuan
Copy link
Contributor

Description

Deal to change in related contracts, I will help organize the continuous development/review of the #11353.

Refactoring correctWithDefaultValue function in lib/corector/utils.cpp

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Owen-Liuyuxuan Owen-Liuyuxuan added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test labels Nov 13, 2025
@Owen-Liuyuxuan
Copy link
Contributor Author

Owen-Liuyuxuan commented Nov 13, 2025

image

Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
@Owen-Liuyuxuan
Copy link
Contributor Author

@technolojin Please check this new PR, which based on my personal repos and I can react faster.

Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
@Owen-Liuyuxuan Owen-Liuyuxuan added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.94%. Comparing base (cd9ca45) to head (2958b39).

Files with missing lines Patch % Lines
.../autoware_shape_estimation/lib/corrector/utils.cpp 91.66% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11631      +/-   ##
==========================================
+ Coverage   17.83%   17.94%   +0.11%     
==========================================
  Files        1744     1746       +2     
  Lines      121773   121804      +31     
  Branches    42800    42793       -7     
==========================================
+ Hits        21722    21862     +140     
+ Misses      81846    81822      -24     
+ Partials    18205    18120      -85     
Flag Coverage Δ *Carryforward flag
daily 20.04% <ø> (+0.01%) ⬆️ Carriedforward from edf6285
daily-cuda 17.85% <ø> (+0.01%) ⬆️ Carriedforward from edf6285
differential 16.57% <91.66%> (?)
differential-cuda 12.38% <91.66%> (?)
total-cuda 17.85% <ø> (+0.02%) ⬆️ Carriedforward from edf6285

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:require-cuda-build-and-test type:documentation Creating or refining documentation. (auto-assigned)

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant