Skip to content

feat(traffic_light_filter): add support for amber light#12076

Open
maxime-clem wants to merge 16 commits intoautowarefoundation:mainfrom
maxime-clem:feat/traffic_light_filter-amber_light
Open

feat(traffic_light_filter): add support for amber light#12076
maxime-clem wants to merge 16 commits intoautowarefoundation:mainfrom
maxime-clem:feat/traffic_light_filter-amber_light

Conversation

@maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Feb 12, 2026

Description

Add support for amber traffic light signals in the TrafficLightFilter of the autoware_trajectory_traffic_rule_filter.

Related links

Private Links:

How was this PR tested?

Notes for reviewers

None.

Interface changes

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
New traffic_light_filter.enable_pass_judge bool Enable pass judge logic. When false, trajectories that cross a amber light are always rejected true
New traffic_light_filter.deceleration_limit double Maximum deceleration [m/s^2] used for pass judge. 2.8
New traffic_light_filter.jerk_limit double Maximum jerk [m/s^3] used for pass judge. 5.0
New traffic_light_filter.delay_response_time double Delay response time [s] used for pass judge. 0.5
New traffic_light_filter.crossing_time_limit double trajectories crossing an amber light are rejected if they cannot cross before this time. 2.75
New traffic_light_filter.treat_amber_light_as_red_light double when true, amber lights are handled like red lights. 1.0

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 12, 2026
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 82.53968% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.19%. Comparing base (8d07c62) to head (9ff3e6f).

Files with missing lines Patch % Lines
...c_rule_filter/src/filters/traffic_light_filter.cpp 81.81% 2 Missing and 8 partials ⚠️
...ffic_rule_filter/traffic_rule_filter_interface.hpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12076      +/-   ##
==========================================
+ Coverage   18.14%   18.19%   +0.05%     
==========================================
  Files        1841     1843       +2     
  Lines      126694   126948     +254     
  Branches    44501    47099    +2598     
==========================================
+ Hits        22984    23100     +116     
- Misses      84545    84723     +178     
+ Partials    19165    19125      -40     
Flag Coverage Δ *Carryforward flag
daily 20.63% <ø> (-0.01%) ⬇️ Carriedforward from 50491d9
daily-cuda 18.13% <ø> (-0.01%) ⬇️ Carriedforward from 50491d9
differential 13.69% <82.53%> (?)
total-cuda 18.13% <ø> (-0.01%) ⬇️ Carriedforward from 50491d9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxime-clem maxime-clem force-pushed the feat/traffic_light_filter-amber_light branch from 4bf9c5f to 7d1d821 Compare February 16, 2026 08:46
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 16, 2026
traffic_light_filter:
deceleration_limit:
type: double
default_value: -2.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: Please align with README. Same for other values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reworking the function to calculate the ego stop distance (the current one being buggy): autowarefoundation/autoware_core#849
Once the above PR is merged I will update the PR and the parameters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@go-sakayori I have updated the documentation and the parameters.

@maxime-clem maxime-clem force-pushed the feat/traffic_light_filter-amber_light branch 2 times, most recently from bfafd3e to e3a14be Compare February 26, 2026 02:38
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the feat/traffic_light_filter-amber_light branch from e3a14be to 50491d9 Compare February 26, 2026 03:46
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

2 participants