feat(traffic_light_filter): add support for amber light#12076
feat(traffic_light_filter): add support for amber light#12076maxime-clem wants to merge 16 commits intoautowarefoundation:mainfrom
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12076 +/- ##
==========================================
+ Coverage 18.14% 18.19% +0.05%
==========================================
Files 1841 1843 +2
Lines 126694 126948 +254
Branches 44501 47099 +2598
==========================================
+ Hits 22984 23100 +116
- Misses 84545 84723 +178
+ Partials 19165 19125 -40
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...ing/autoware_trajectory_traffic_rule_filter/config/trajectory_traffic_rule_filter.param.yaml
Outdated
Show resolved
Hide resolved
planning/autoware_trajectory_traffic_rule_filter/param/parameter_struct.yaml
Outdated
Show resolved
Hide resolved
4bf9c5f to
7d1d821
Compare
planning/autoware_trajectory_traffic_rule_filter/src/filters/traffic_light_filter.cpp
Outdated
Show resolved
Hide resolved
| traffic_light_filter: | ||
| deceleration_limit: | ||
| type: double | ||
| default_value: -2.8 |
There was a problem hiding this comment.
nits: Please align with README. Same for other values
There was a problem hiding this comment.
I am reworking the function to calculate the ego stop distance (the current one being buggy): autowarefoundation/autoware_core#849
Once the above PR is merged I will update the PR and the parameters.
There was a problem hiding this comment.
@go-sakayori I have updated the documentation and the parameters.
bfafd3e to
e3a14be
Compare
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
e3a14be to
50491d9
Compare
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Description
Add support for amber traffic light signals in the
TrafficLightFilterof theautoware_trajectory_traffic_rule_filter.Related links
Private Links:
How was this PR tested?
Notes for reviewers
None.
Interface changes
ROS Parameter Changes
Additions and removals
traffic_light_filter.enable_pass_judgetraffic_light_filter.deceleration_limittraffic_light_filter.jerk_limittraffic_light_filter.delay_response_timetraffic_light_filter.crossing_time_limittraffic_light_filter.treat_amber_light_as_red_lightEffects on system behavior
None.