feat(autoware_calibration_status_classifier): cuda 12.0 build compatibility#12193
Open
amadeuszsz wants to merge 2 commits intoautowarefoundation:mainfrom
Open
Conversation
…ibility Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
amadeuszsz
added
the
run:build-and-test-differential
amadeuszsz
changed the title
github-actions
bot
added
the
component:sensing
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
amadeuszsz
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12193 +/- ##
==========================================
- Coverage 18.13% 18.12% -0.02%
==========================================
Files 1841 1842 +1
Lines 126705 126812 +107
Branches 44507 44565 +58
==========================================
+ Hits 22983 22984 +1
- Misses 84556 84663 +107
+ Partials 19166 19165 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Latest PR related to NVCC flags aligned compatibility with minimum required version for Autoware. However, downstream projects may use custom CI/CD pipeline or local builds, where CUDA version is below 12.8. This PR adjust flags and make build possible for pipelines with CUDA 12.0+.
Resulting flags for:
Related links
Parent Issue:
autowarefoundation/autoware#6789
How was this PR tested?
Notes for reviewers
Even though this modification keeps flags compatible with user's CUDA version, we can't assure compatibility with CUDA < 12.8 for any incoming features since Autoware is developed under CUDA 12.8 environment.
Interface changes
None.
Effects on system behavior
None.