feat(autoware_cuda_pointcloud_preprocessor): cuda 12.0 build compatibility#12194
Conversation
…bility Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12194 +/- ##
==========================================
- Coverage 18.14% 18.11% -0.03%
==========================================
Files 1841 1843 +2
Lines 126693 126897 +204
Branches 44501 44671 +170
==========================================
Hits 22983 22983
- Misses 84544 84748 +204
Partials 19166 19166
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Possible duplicate of TIER IV branch: tier4#2707 |
mojomex
left a comment
There was a problem hiding this comment.
Change itself LGTM. Is the plan to have 1 PR per package? Otherwise the tier4#2707 PR could be cherry-picked instead.
All sub-projects may need similar change, therefore change in upstream seems more appropriate. Also linked PR does not come with forward compatibility if build with CUDA < 12.8, so for consistency purposes I would prefer to apply changes from this PR. memo: I experimented with more robust approaches, but unfortunately not all the environments can discover architecture properly and therefore fallback to |
Description
Latest PR related to NVCC flags aligned compatibility with minimum required version for Autoware. However, downstream projects may use custom CI/CD pipeline or local builds, where CUDA version is below 12.8. This PR adjust flags and make build possible for pipelines with CUDA 12.0+.
Resulting flags for:
Related links
Parent Issue:
autowarefoundation/autoware#6789
How was this PR tested?
Notes for reviewers
Even though this modification keeps flags compatible with user's CUDA version, we can't assure compatibility with CUDA < 12.8 for any incoming features since Autoware is developed under CUDA 12.8 environment.
Interface changes
None.
Effects on system behavior
None.