refactor(simple planning simulator): replace tier4_autoware_msgs by autoware_msgs#12530
Draft
sasakisasaki wants to merge 18 commits intoautowarefoundation:mainfrom
Conversation
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
* This commit applies the missing fix for the following commit
- autowarefoundation@f0efc76
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…dummy-perception-publisher' of github.com:sasakisasaki/autoware.universe into migration-from-tier4-autoware-msgs-to-autoware-msgs-in-dummy-perception-publisher Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…re-msgs-in-dummy-perception-publisher
…re-msgs-in-dummy-perception-publisher
…re-msgs-in-dummy-perception-publisher
…re-msgs-in-dummy-perception-publisher
* Apply the following review comment
- autowarefoundation#12499 (comment)
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…s` to `autoware_vehicle_msgs` Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
* We are not using `tier4_vehicle_msgs::srv::ControlModeRequest` Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
simple planning simulator): replace tier4_autoware_msgs by autoware_msgs
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…sgs-to-autoware-msgs-in-dummy-perception-publisher' into migration-from-tier4-autoware-msgs-to-autoware-msgs-in-simple-planning-simulator Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
* Follow the following two commits on `autoware_msgs` side:
- autowarefoundation/autoware_msgs@a75eff5
- autowarefoundation/autoware_msgs@42732b2
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
autoware_msgsandautoware_universeare merged. As the PRs below are merged, I'll make this PR as "Ready for review".autoware_vehicle_msgs): port actuation command/status messages fromtier4_vehicle_msgsautoware_msgs#165dummy_perception_publisher): replacetier4_simulation_msgsbyautoware_simulation_msgs#12499This PR refactors
autoware_simple_planning_simulatorto useautoware_vehicle_msgsactuation messages and remove thetier4_vehicle_msgsdependency.Related links
How was this PR tested?
Using Planning Simulator
Based on this PR, and also this PR on the
autoware_msgsside, I tested the functionality by using a planning simulator following this tutorial.To test if the dummy objects are created, I performed:
I believe these observation is consistent that of without this PR.
Using TIER IV Internal Scenario Simulator
Notes for reviewers
None
Interface changes
Switched actuation messages to
autoware_vehicle_msgsand removedtier4_vehicle_msgsdependency.Effects on system behavior
Non