Skip to content

refactor(autoware_traffic_light_map_based_detector): rename functions to snake_case#12551

Merged
interimadd merged 2 commits intoautowarefoundation:mainfrom
interimadd:traffic-light-map-based-detector-rename-function-names-to-snake-case
May 11, 2026
Merged

refactor(autoware_traffic_light_map_based_detector): rename functions to snake_case#12551
interimadd merged 2 commits intoautowarefoundation:mainfrom
interimadd:traffic-light-map-based-detector-rename-function-names-to-snake-case

Conversation

@interimadd
Copy link
Copy Markdown
Contributor

Description

Rename camelCase function names to snake_case in the autoware_traffic_light_map_based_detector package to follow the Autoware C++ coding guideline:
https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/languages/cpp/#use-lower-snake-case-for-function-names-required-partially-automated

Test suite/case names in test_utils.cpp are aligned to PascalCase to match the other test suites in this package and comply with Google Test naming guidance. No behavior changes.

Related links

Parent Issue:

  • Link

How was this PR tested?

  • colcon build --packages-select autoware_traffic_light_map_based_detector
  • colcon test --packages-select autoware_traffic_light_map_based_detector --event-handlers console_cohesion+ — all 7 tests pass.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

… to snake_case

Rename camelCase function names to snake_case per Autoware coding
conventions. Test suite/case names in test_utils.cpp are aligned to
PascalCase to match the other test suites in the package and comply
with Google Test naming guidance.

Signed-off-by: Takahisa.Ishikawa <takahisa.ishikawa@tier4.jp>
@interimadd interimadd added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 7, 2026
@github-actions github-actions Bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

…er rename

Wrap lines that exceeded the 100-character limit after renaming
functions to snake_case, fixing cpplint failures in CI.

Signed-off-by: Takahisa.Ishikawa <takahisa.ishikawa@tier4.jp>
Copy link
Copy Markdown
Contributor

@a-maumau a-maumau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the coding style!
LGTM.

@interimadd interimadd merged commit 4d6292d into autowarefoundation:main May 11, 2026
27 of 28 checks passed
@github-project-automation github-project-automation Bot moved this from To Triage to Done in Software Working Group May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants