refactor(autoware_traffic_light_map_based_detector): rename functions to snake_case#12551
Merged
interimadd merged 2 commits intoautowarefoundation:mainfrom May 11, 2026
Conversation
… to snake_case Rename camelCase function names to snake_case per Autoware coding conventions. Test suite/case names in test_utils.cpp are aligned to PascalCase to match the other test suites in the package and comply with Google Test naming guidance. Signed-off-by: Takahisa.Ishikawa <takahisa.ishikawa@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…er rename Wrap lines that exceeded the 100-character limit after renaming functions to snake_case, fixing cpplint failures in CI. Signed-off-by: Takahisa.Ishikawa <takahisa.ishikawa@tier4.jp>
a-maumau
approved these changes
May 11, 2026
Contributor
a-maumau
left a comment
There was a problem hiding this comment.
Thank you for fixing the coding style!
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename camelCase function names to snake_case in the
autoware_traffic_light_map_based_detectorpackage to follow the Autoware C++ coding guideline:https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/languages/cpp/#use-lower-snake-case-for-function-names-required-partially-automated
Test suite/case names in
test_utils.cppare aligned to PascalCase to match the other test suites in this package and comply with Google Test naming guidance. No behavior changes.Related links
Parent Issue:
How was this PR tested?
colcon build --packages-select autoware_traffic_light_map_based_detectorcolcon test --packages-select autoware_traffic_light_map_based_detector --event-handlers console_cohesion+— all 7 tests pass.Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.