perf(autoware_tensorrt_plugins): remove Thrust from sort kernels#12554
perf(autoware_tensorrt_plugins): remove Thrust from sort kernels#12554mojomex wants to merge 8 commits intoautowarefoundation:mainfrom
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
ff5ad6d to
23b3f79
Compare
|
@codex review. Is the implementation memory safe and has no race conditions? Do the unit tests guarantee correct behavior? Is the implementation as concise and readable as possible? |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex Code isn't documented and behavior is not immediately obvious to the reader, e.g. |
|
To use Codex here, create an environment for this repo. |
4d19d0e to
2165fc5
Compare
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
2165fc5 to
0372bf9
Compare
Stack
This PR is stacked on #12561, which adds the reference kernel tests and the minimal pre-existing
uniquecounts fix those tests expose. Review #12561 first; this PR contains the no-thrust implementation and cleanup on top.Summary
Removes Thrust from the TensorRT plugin sort kernels and keeps the mutable unique temp-storage follow-up used in the benchmarked variant.
This draft PR corresponds to the benchmarked variant
ptv3-t18-no-thrust-c8f76ed-20260506.All PRs in this cohort target
main; each later PR contains the changes benchmarked in the earlier ones.Cohort
ptv3-t18-no-thrust-c8f76ed-20260506)ptv3-t18-no-thrust-no-alloc-e9515b790-20260506)ptv3-t18-no-thrust-no-alloc-no-sync-13f3672a0-20260506)ptv3-t18-no-thrust-no-alloc-no-sync-maxnumel-47bf5656f-20260506)ptv3-t18-no-thrust-no-alloc-no-sync-maxnumel-maxauxstreams1)Benchmarks
Source report:
reports/2026-05-07_22-20-12/report.mdTotal Latency Summary
Relative Performance