Skip to content

fix(autoware_geo_pose_projector): declare the map projector info input as a remap target - #13334

Open
technolojin wants to merge 1 commit into
autowarefoundation:mainfrom
technolojin:fix/node-design-localization
Open

fix(autoware_geo_pose_projector): declare the map projector info input as a remap target#13334
technolojin wants to merge 1 commit into
autowarefoundation:mainfrom
technolojin:fix/node-design-localization

Conversation

@technolojin

@technolojin technolojin commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

Split of #13298 — the localization slice.

GeoPoseProjector pins its map_projector_info subscriber to /map/map_projector_info with global:. A port pinned with global: connects outside the design graph on a fixed topic: link_manager skips any connection whose target is a global input port, and the exporter emits no remap. With remap_target: the port takes part in the graph like any other, while the launcher still binds it to the official name.

Related links

Parent Issue:

  • None

Related:

How was this PR tested?

Notes for reviewers

Design metadata only; no launch file or node source is touched.

Interface changes

None. The topic name is unchanged.

Effects on system behavior

None.

@github-actions github-actions Bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Sep 7, 2026
@technolojin technolojin self-assigned this Sep 7, 2026
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 7, 2026
@technolojin
technolojin marked this pull request as ready for review September 7, 2026 04:32
…t as a remap target

The map_projector_info subscriber is pinned to /map/map_projector_info with
global:, which keeps the port out of the design graph: link_manager skips any
connection whose target is a global input port and the exporter emits no remap.
remap_target: keeps the same fixed topic name while letting the port take part
in the graph.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Motsu-san Motsu-san left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I think there's no side-effect on Localization functions)

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.48%. Comparing base (f540393) to head (74db981).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13334      +/-   ##
==========================================
- Coverage   20.49%   20.48%   -0.01%     
==========================================
  Files        1948     1948              
  Lines      137202   137201       -1     
  Branches    48933    48932       -1     
==========================================
- Hits        28113    28107       -6     
  Misses      86314    86314              
- Partials    22775    22780       +5     
Flag Coverage Δ *Carryforward flag
daily ?
full-suite 20.48% <ø> (+<0.01%) ⬆️ Carriedforward from f540393

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

3 participants