fix(autoware_geo_pose_projector): declare the map projector info input as a remap target - #13334
Open
technolojin wants to merge 1 commit into
Open
Conversation
technolojin
marked this pull request as ready for review
September 7, 2026 04:32
technolojin
requested review from
Motsu-san,
TaikiYamada4 and
YamatoAndo
as code owners
September 7, 2026 04:32
…t as a remap target The map_projector_info subscriber is pinned to /map/map_projector_info with global:, which keeps the port out of the design graph: link_manager skips any connection whose target is a global input port and the exporter emits no remap. remap_target: keeps the same fixed topic name while letting the port take part in the graph. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
technolojin
force-pushed
the
fix/node-design-localization
branch
from
September 7, 2026 04:36
945515b to
74db981
Compare
technolojin
marked this pull request as draft
September 7, 2026 04:52
technolojin
marked this pull request as ready for review
September 7, 2026 04:54
YamatoAndo
approved these changes
Sep 7, 2026
Motsu-san
approved these changes
Sep 7, 2026
Motsu-san
left a comment
Contributor
There was a problem hiding this comment.
LGTM (I think there's no side-effect on Localization functions)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13334 +/- ##
==========================================
- Coverage 20.49% 20.48% -0.01%
==========================================
Files 1948 1948
Lines 137202 137201 -1
Branches 48933 48932 -1
==========================================
- Hits 28113 28107 -6
Misses 86314 86314
- Partials 22775 22780 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split of #13298 — the
localizationslice.GeoPoseProjectorpins itsmap_projector_infosubscriber to/map/map_projector_infowithglobal:. A port pinned withglobal:connects outside the design graph on a fixed topic:link_managerskips any connection whose target is a global input port, and the exporter emits no remap. Withremap_target:the port takes part in the graph like any other, while the launcher still binds it to the official name.Related links
Parent Issue:
Related:
How was this PR tested?
pre-commit run --files localization/autoware_geo_pose_projector/design/GeoPoseProjector.node.yaml(Autoware System Design Format lint, prettier, yamllint) passes.autoware_sample_designsdeployment build.AutowareSamplereference system was built and run with these designs against feat(autoware_sample_designs): compose the AD API, system and vehicle components from design modules autoware_launch#1976:colcon build --packages-select autoware_sample_designssucceeds with zero warnings and exports all four modes (Runtime, LoggingSimulation, PlanningSimulation, E2ESimulation), and planning simulation reaches autonomous mode.Notes for reviewers
Design metadata only; no launch file or node source is touched.
Interface changes
None. The topic name is unchanged.
Effects on system behavior
None.