Skip to content

fix(design): align the simulator node designs with the packages they describe - #13335

Open
technolojin wants to merge 2 commits into
autowarefoundation:mainfrom
technolojin:fix/node-design-simulator
Open

fix(design): align the simulator node designs with the packages they describe#13335
technolojin wants to merge 2 commits into
autowarefoundation:mainfrom
technolojin:fix/node-design-simulator

Conversation

@technolojin

@technolojin technolojin commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

Split of #13298 — the simulator slice.

VehicleDoorSimulator.node.yaml declares plugin: autoware::vehicle_door_simulator::DummyDoors, but autoware_vehicle_door_simulator builds its node with ament_auto_add_executable and registers no component with RCLCPP_COMPONENTS_REGISTER_NODE. The plugin: field is dropped; the design keeps its executable:.

DummyDiagPublisher declares the parameters its launcher passes: the required diagnostics come from the system-side parameter files, so the package defaults are empty and the node takes a second parameter file.

Related links

Parent Issue:

  • None

Related:

How was this PR tested?

  • pre-commit run --files simulator/autoware_vehicle_door_simulator/design/VehicleDoorSimulator.node.yaml (Autoware System Design Format lint, prettier, yamllint) passes.
  • Checked against CMakeLists.txt and the absence of RCLCPP_COMPONENTS_REGISTER_NODE in the package.
  • The AutowareSample reference system was built and run with these designs against feat(autoware_sample_designs): compose the AD API, system and vehicle components from design modules autoware_launch#1976: colcon build --packages-select autoware_sample_designs succeeds with zero warnings and exports all four modes (Runtime, LoggingSimulation, PlanningSimulation, E2ESimulation), and planning simulation reaches autonomous mode.

Notes for reviewers

Design metadata only; no launch file or node source is touched.

Interface changes

None.

Effects on system behavior

None.

@technolojin technolojin self-assigned this Sep 7, 2026
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 7, 2026
@technolojin
technolojin marked this pull request as ready for review September 7, 2026 04:33
…node design

The package builds its node with ament_auto_add_executable and registers no
component, so the design has an executable but no plugin.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin
technolojin force-pushed the fix/node-design-simulator branch from c4d0d45 to f6ade67 Compare September 7, 2026 04:36
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

…er passes

The required diagnostics come from the system-side parameter files, so the
package defaults are empty and the node takes a second parameter file.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin
technolojin marked this pull request as draft September 7, 2026 04:52
@technolojin
technolojin marked this pull request as ready for review September 7, 2026 04:54
@technolojin technolojin changed the title fix(autoware_vehicle_door_simulator): drop the plugin field from the node design fix(design): align the simulator node designs with the packages they describe Sep 7, 2026
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.48%. Comparing base (f540393) to head (55fc6ea).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13335      +/-   ##
==========================================
- Coverage   20.49%   20.48%   -0.01%     
==========================================
  Files        1948     1948              
  Lines      137202   137201       -1     
  Branches    48933    48932       -1     
==========================================
- Hits        28113    28107       -6     
  Misses      86314    86314              
- Partials    22775    22780       +5     
Flag Coverage Δ *Carryforward flag
daily ?
full-suite 20.48% <ø> (+<0.01%) ⬆️ Carriedforward from f6ade67

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant