fix(design): align the simulator node designs with the packages they describe - #13335
Open
technolojin wants to merge 2 commits into
Open
fix(design): align the simulator node designs with the packages they describe#13335technolojin wants to merge 2 commits into
technolojin wants to merge 2 commits into
Conversation
technolojin
marked this pull request as ready for review
September 7, 2026 04:33
technolojin
requested review from
isamu-takagi and
sasakisasaki
as code owners
September 7, 2026 04:33
…node design The package builds its node with ament_auto_add_executable and registers no component, so the design has an executable but no plugin. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin
force-pushed
the
fix/node-design-simulator
branch
from
September 7, 2026 04:36
c4d0d45 to
f6ade67
Compare
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…er passes The required diagnostics come from the system-side parameter files, so the package defaults are empty and the node takes a second parameter file. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin
marked this pull request as draft
September 7, 2026 04:52
technolojin
marked this pull request as ready for review
September 7, 2026 04:54
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13335 +/- ##
==========================================
- Coverage 20.49% 20.48% -0.01%
==========================================
Files 1948 1948
Lines 137202 137201 -1
Branches 48933 48932 -1
==========================================
- Hits 28113 28107 -6
Misses 86314 86314
- Partials 22775 22780 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split of #13298 — the
simulatorslice.VehicleDoorSimulator.node.yamldeclaresplugin: autoware::vehicle_door_simulator::DummyDoors, butautoware_vehicle_door_simulatorbuilds its node withament_auto_add_executableand registers no component withRCLCPP_COMPONENTS_REGISTER_NODE. Theplugin:field is dropped; the design keeps itsexecutable:.DummyDiagPublisherdeclares the parameters its launcher passes: the required diagnostics come from the system-side parameter files, so the package defaults are empty and the node takes a second parameter file.Related links
Parent Issue:
Related:
How was this PR tested?
pre-commit run --files simulator/autoware_vehicle_door_simulator/design/VehicleDoorSimulator.node.yaml(Autoware System Design Format lint, prettier, yamllint) passes.CMakeLists.txtand the absence ofRCLCPP_COMPONENTS_REGISTER_NODEin the package.AutowareSamplereference system was built and run with these designs against feat(autoware_sample_designs): compose the AD API, system and vehicle components from design modules autoware_launch#1976:colcon build --packages-select autoware_sample_designssucceeds with zero warnings and exports all four modes (Runtime, LoggingSimulation, PlanningSimulation, E2ESimulation), and planning simulation reaches autonomous mode.Notes for reviewers
Design metadata only; no launch file or node source is touched.
Interface changes
None.
Effects on system behavior
None.