Skip to content

fix(design): align the evaluator node designs with the packages they describe - #13341

Open
technolojin wants to merge 1 commit into
autowarefoundation:mainfrom
technolojin:fix/node-design-evaluator
Open

fix(design): align the evaluator node designs with the packages they describe#13341
technolojin wants to merge 1 commit into
autowarefoundation:mainfrom
technolojin:fix/node-design-evaluator

Conversation

@technolojin

@technolojin technolojin commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

Split of #13298 — the evaluator slice. Three classes of fix.

1. Fixed-name interfaces declared as remap targets

A port pinned with global: connects outside the design graph on a fixed topic: link_manager skips any connection whose target is a global input port, and the exporter emits no remap. With remap_target: the port takes part in the graph like any other, while the launcher still binds it to the official name.

Converted across autoware_evaluation_adapter (AutowareEngage, VelocityLimit — their operation mode, velocity limit and external API service ports), autoware_perception_online_evaluator (the two latency inputs) and autoware_scenario_simulator_v2_adapter (MetricConverter's three metric inputs and its overall diagnostics output). /diagnostics stays global:.

2. Launch fields and interface types that do not match the package

design field was is
ControlEvaluator plugin autoware::control_evaluator::ControlEvaluatorNode control_diagnostics::ControlEvaluatorNode
ControlEvaluator metrics autoware_control_msgs/msg/ControlEvaluation (no such type) tier4_metric_msgs/msg/MetricArray
PlanningEvaluator metrics autoware_planning_msgs/msg/PlanningAnalysis (no such type) tier4_metric_msgs/msg/MetricArray

AutowareEngage and VelocityLimit are components registered with RCLCPP_COMPONENTS_REGISTER_NODE and build no executable of their own, so their executable: field is dropped.

3. ControlEvaluator planning factor inputs

The eleven planning factor subscribers are pinned to their /planning/planning_factors/* topics via remap_target; merge_from_private and no_drivable_lane were missing from the design entirely.

Related links

Parent Issue:

  • None

Related:

How was this PR tested?

Notes for reviewers

Design metadata only; no launch file or node source is touched.

Interface changes

None. The added ControlEvaluator subscribers are topics the node already subscribes to.

Effects on system behavior

None.

…describe

The fixed-name ports of the evaluation adapters, the online perception
evaluator and the metric converter are pinned with global:, which keeps them
out of the design graph: link_manager skips any connection whose target is a
global input port and the exporter emits no remap. remap_target: keeps the same
topic and service names while letting the ports take part in the graph.
/diagnostics stays global:.

ControlEvaluator names a plugin class in the wrong namespace, publishes
tier4_metric_msgs/MetricArray rather than the non-existent
autoware_control_msgs/ControlEvaluation, and subscribes to eleven planning
factor topics under /planning/planning_factors, two of which were missing.
PlanningEvaluator publishes the same metric type.

The evaluation adapter nodes are components with no executable of their own.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin
technolojin force-pushed the fix/node-design-evaluator branch from 39ee0f9 to 60954f2 Compare September 7, 2026 04:36
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin
technolojin marked this pull request as draft September 7, 2026 04:52
@technolojin
technolojin marked this pull request as ready for review September 7, 2026 04:54
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.48%. Comparing base (f540393) to head (60954f2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13341      +/-   ##
==========================================
- Coverage   20.49%   20.48%   -0.01%     
==========================================
  Files        1948     1948              
  Lines      137202   137201       -1     
  Branches    48933    48932       -1     
==========================================
- Hits        28113    28107       -6     
+ Misses      86314    86313       -1     
- Partials    22775    22781       +6     
Flag Coverage Δ *Carryforward flag
daily ?
full-suite 20.48% <ø> (+<0.01%) ⬆️ Carriedforward from f540393

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

3 participants