fix(design): align the evaluator node designs with the packages they describe - #13341
Open
technolojin wants to merge 1 commit into
Open
fix(design): align the evaluator node designs with the packages they describe#13341technolojin wants to merge 1 commit into
technolojin wants to merge 1 commit into
Conversation
technolojin
marked this pull request as ready for review
September 7, 2026 04:35
technolojin
requested review from
TakaHoribe,
YoshiRi,
danielsanchezaran,
isamu-takagi,
kosuke55,
ktro2828,
kyoichi-sugahara,
maxime-clem,
rej55,
sasakisasaki,
takayuki5168 and
xtk8532704
as code owners
September 7, 2026 04:35
…describe The fixed-name ports of the evaluation adapters, the online perception evaluator and the metric converter are pinned with global:, which keeps them out of the design graph: link_manager skips any connection whose target is a global input port and the exporter emits no remap. remap_target: keeps the same topic and service names while letting the ports take part in the graph. /diagnostics stays global:. ControlEvaluator names a plugin class in the wrong namespace, publishes tier4_metric_msgs/MetricArray rather than the non-existent autoware_control_msgs/ControlEvaluation, and subscribes to eleven planning factor topics under /planning/planning_factors, two of which were missing. PlanningEvaluator publishes the same metric type. The evaluation adapter nodes are components with no executable of their own. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin
force-pushed
the
fix/node-design-evaluator
branch
from
September 7, 2026 04:36
39ee0f9 to
60954f2
Compare
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
xtk8532704
approved these changes
Sep 7, 2026
technolojin
marked this pull request as draft
September 7, 2026 04:52
technolojin
marked this pull request as ready for review
September 7, 2026 04:54
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13341 +/- ##
==========================================
- Coverage 20.49% 20.48% -0.01%
==========================================
Files 1948 1948
Lines 137202 137201 -1
Branches 48933 48932 -1
==========================================
- Hits 28113 28107 -6
+ Misses 86314 86313 -1
- Partials 22775 22781 +6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ktro2828
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split of #13298 — the
evaluatorslice. Three classes of fix.1. Fixed-name interfaces declared as remap targets
A port pinned with
global:connects outside the design graph on a fixed topic:link_managerskips any connection whose target is a global input port, and the exporter emits no remap. Withremap_target:the port takes part in the graph like any other, while the launcher still binds it to the official name.Converted across
autoware_evaluation_adapter(AutowareEngage,VelocityLimit— their operation mode, velocity limit and external API service ports),autoware_perception_online_evaluator(the two latency inputs) andautoware_scenario_simulator_v2_adapter(MetricConverter's three metric inputs and its overall diagnostics output)./diagnosticsstaysglobal:.2. Launch fields and interface types that do not match the package
ControlEvaluatorautoware::control_evaluator::ControlEvaluatorNodecontrol_diagnostics::ControlEvaluatorNodeControlEvaluatormetricsautoware_control_msgs/msg/ControlEvaluation(no such type)tier4_metric_msgs/msg/MetricArrayPlanningEvaluatormetricsautoware_planning_msgs/msg/PlanningAnalysis(no such type)tier4_metric_msgs/msg/MetricArrayAutowareEngageandVelocityLimitare components registered withRCLCPP_COMPONENTS_REGISTER_NODEand build no executable of their own, so theirexecutable:field is dropped.3.
ControlEvaluatorplanning factor inputsThe eleven planning factor subscribers are pinned to their
/planning/planning_factors/*topics viaremap_target;merge_from_privateandno_drivable_lanewere missing from the design entirely.Related links
Parent Issue:
Related:
How was this PR tested?
pre-commit run --fileson all six changed designs (Autoware System Design Format lint, prettier, yamllint) passes.CMakeLists.txtandRCLCPP_COMPONENTS_REGISTER_NODE; interface types against the installed.msgdefinitions and thecreate_publisher/create_subscriptioncall sites.autoware_sample_designsdeployment build across four modes.AutowareSamplereference system was built and run with these designs against feat(autoware_sample_designs): compose the AD API, system and vehicle components from design modules autoware_launch#1976:colcon build --packages-select autoware_sample_designssucceeds with zero warnings and exports all four modes (Runtime, LoggingSimulation, PlanningSimulation, E2ESimulation), and planning simulation reaches autonomous mode.Notes for reviewers
Design metadata only; no launch file or node source is touched.
Interface changes
None. The added
ControlEvaluatorsubscribers are topics the node already subscribes to.Effects on system behavior
None.