fix(trajectory_selector, trajectory_validator): sync changes to the - #13344
Open
zulfaqar-azmi-t4 wants to merge 2 commits into
Open
fix(trajectory_selector, trajectory_validator): sync changes to the#13344zulfaqar-azmi-t4 wants to merge 2 commits into
zulfaqar-azmi-t4 wants to merge 2 commits into
Conversation
…validation report Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…ilters Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
requested review from
Kotakku,
danielsanchezaran,
go-sakayori,
maxime-clem,
mkquda and
yukkysaito
as code owners
September 7, 2026 05:44
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13344 +/- ##
=======================================
Coverage 20.49% 20.49%
=======================================
Files 1948 1948
Lines 137202 137244 +42
Branches 48933 48953 +20
=======================================
+ Hits 28113 28126 +13
- Misses 86314 86326 +12
- Partials 22775 22792 +17
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mkquda
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports the trajectory selector and validator improvements from the TIER IV
feat/v0.64/e2ebranch that do not depend on TIER IV-only filters or packages.Route reaches the validator filters. The crosswalk and traffic light filters need the current route, but the selector never provided it, so both filters rejected every trajectory whenever they were enabled. The selector now subscribes to the route and passes it on.
Missing traffic light input no longer rejects trajectories. On maps without traffic lights, or before the first signal message arrives, the traffic light filter treated the absent input as an error. An absent input is now treated as "no known signals".
Validation results carry risk levels to the caller. The validator now hands the selector the full validation report, including the per-trajectory risk level, instead of only the surviving trajectories. Published topics are unchanged. This prepares for a follow-up PR where the boundary departure filter reports a low caution risk for trajectories running close to an uncrossable boundary.
Filters publish planning factors. Filters can attach planning factors to their result, and the validator publishes them on
/planning/planning_factors/trajectory_validator. The crosswalk filter reports a STOP factor naming the obstructing pedestrian when it rejects a trajectory. This makes rejections visible in RViz and to downstream consumers.Not included: the ranker and adapter integration into the selector node from the TIER IV branch. Upstream keeps
autoware_trajectory_rankerandautoware_trajectory_adapteras standalone nodes, and merging them into the selector is an architecture change to be discussed separately.Related links
Parent Issue:
Source PRs (TIER IV
feat/v0.64/e2e):How was this PR tested?
Built with
-DBUILD_TESTING=ONand ran the package tests:autoware_trajectory_validator: 7/7 passedautoware_trajectory_selector: 5/5 passedNotes for reviewers
The route is optional in the selector. Filters that need it return their own error, so a missing route disables those filters only, instead of blocking validation of all trajectories.
Interface changes
Topic changes
Additions and removals
~/input/routeautoware_planning_msgs/msg/LaneletRoute/planning/planning_factors/trajectory_validatorautoware_internal_planning_msgs/msg/PlanningFactorArrayEffects on system behavior
Crosswalk and traffic light filters now work when enabled; previously they rejected every trajectory. Trajectories are no longer rejected on maps without traffic light input. Rejections by the crosswalk filter are visible as planning factors.