Disable --//bazel:use_local_flex_bison that won't work with bazel 8
#2449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around chipsalliance#2435 : bazel 8 does not allow a simple toolchain switch with select(). If somone wants to help with bazel knowledge to re-enable this, undo this patch and send a fix on top. Having said that, the original reason for this flag used to be that rules bison and flex didn't compile on Mac and Windows. These reasons don't seem to apply anymore. Fixes: chipsalliance#2435
hzeller
force-pushed
the
feature-20250826-no-use-local-bison
branch
from
61386b8 to
7854b56
Compare
Collaborator
Author
|
sigh. Looks like for Windows, we would indeed need a toolchain switch. Converting to draft for now, waiting for someone who can tackle the bazel challenge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around #2435 : bazel 8 does not allow a simple toolchain switch with select(). If somone wants to help with bazel knowledge to re-enable this, undo this patch and send a fix on top.
Having said that, the original reason for this flag used to be that rules bison and flex didn't compile on Mac and Windows. These reasons don't seem to apply anymore.