Fix formatter abort on non-ANSI wire signed ports - #2581
Open
kbrunham-intel wants to merge 1 commit into
Open
Conversation
Module body ports such as `input wire signed [15:0] sig1` put `signed` before `wire` in kDataType. The formatter walks CST order and CHECK-failed in the tree-unwrapper (issue chipsalliance#2008).
This was referenced Aug 18, 2026
kbrunham-intel
marked this pull request as ready for review
August 18, 2026 01:34
Contributor
Author
|
Hi @hzeller. Please consider this change. It addresses 3 cases filed for the formatter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input wire signed [15:0] sig1builtkDataTypechildren in reverse source order (signedbeforewire). The formatter walks CST order, so it CHECK-failed in the tree-unwrapper.input bit signed: wrap net/var type then signing inkDataTypePrimitiveso leaf visit order matches the file.logic signed,output/inout, andunsigned.Fixes #2008
Fixes #2474
Fixes #2063
Test plan
bazel test -c opt //verible/verilog/formatting:formatter_test //verible/verilog/CST:port_test //verible/verilog/CST:type_test //verible/verilog/parser:verilog-parser_test