Skip to content

Fix formatter abort on non-ANSI wire signed ports - #2581

Open
kbrunham-intel wants to merge 1 commit into
chipsalliance:masterfrom
kbrunham-intel:fix/2008
Open

Fix formatter abort on non-ANSI wire signed ports#2581
kbrunham-intel wants to merge 1 commit into
chipsalliance:masterfrom
kbrunham-intel:fix/2008

Conversation

@kbrunham-intel

@kbrunham-intel kbrunham-intel commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #2008
Fixes #2474
Fixes #2063

Test plan

Module body ports such as `input wire signed [15:0] sig1` put
`signed` before `wire` in kDataType. The formatter walks CST order
and CHECK-failed in the tree-unwrapper (issue chipsalliance#2008).
@kbrunham-intel

Copy link
Copy Markdown
Contributor Author

Hi @hzeller. Please consider this change. It addresses 3 cases filed for the formatter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

verible-verilog-format crash for special wire signed vectors Crash of formatter on a signed wire Check failure when using signed wires

1 participant