add fillDescriptions to several ESproducers used at HLT (2/N)

[mmusich]

PR description:

This PR is similar in spirit to #47017, #47045, #47079, #47107 and #47136. It adds fillDescriptions (and applies light modification to modernize the source code) to a few ESProducers used at HLT for both Run 3 and Phase 2.

PR validation:

• addOnTests.py runs fine.
• hltPhase2UpgradeIntegrationTests runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47191/43439

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoBTag/Combined/src/CandidateChargeBTagComputer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoTracker/TkNavigation/plugins/NavigationSchoolESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File TrackingTools/GsfTools/plugins/CloseComponentsMergerESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File TrackingTools/GsfTools/plugins/DistanceBetweenComponentsESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File TrackingTools/GsfTracking/plugins/GsfTrajectoryFitterESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File TrackingTools/GsfTracking/plugins/GsfTrajectorySmootherESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File TrackingTools/TransientTrack/plugins/TransientTrackBuilderESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47191/43439/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47191/43439/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47191/43440

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoBTag/Combined/src/CandidateChargeBTagComputer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoTracker/TkNavigation/plugins/NavigationSchoolESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File TrackingTools/GsfTools/plugins/CloseComponentsMergerESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File TrackingTools/GsfTools/plugins/DistanceBetweenComponentsESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File TrackingTools/GsfTracking/plugins/GsfTrajectoryFitterESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File TrackingTools/GsfTracking/plugins/GsfTrajectorySmootherESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File TrackingTools/TransientTrack/plugins/TransientTrackBuilderESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

[cmsbuild]

Pull request #47191 was updated.

[mmusich]

@cmsbuild, please test

[cmsbuild]

Pull request #47191 was updated. @Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-794d71/44007/summary.html
COMMIT: 095f808
CMSSW: CMSSW_15_0_X_2025-01-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47191/44007/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 4107224
• DQMHistoTests: Total failures: 110
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4107094
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 222 log files, 194 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1