add `fillDescriptions` to several `ESproducer`s used at HLT (2/N) #47191

mmusich · 2025-01-27T21:11:34Z

PR description:

This PR is similar in spirit to #47017, #47045, #47079, #47107 and #47136. It adds fillDescriptions (and applies light modification to modernize the source code) to a few ESProducers used at HLT for both Run 3 and Phase 2.

PR validation:

addOnTests.py runs fine.
hltPhase2UpgradeIntegrationTests runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

…scriptions

cmsbuild · 2025-01-27T21:12:06Z

cms-bot internal usage

cmsbuild · 2025-01-27T21:14:39Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47191/43439

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoBTag/Combined/src/CandidateChargeBTagComputer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File RecoTracker/TkNavigation/plugins/NavigationSchoolESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File TrackingTools/GsfTools/plugins/CloseComponentsMergerESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File TrackingTools/GsfTools/plugins/DistanceBetweenComponentsESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File TrackingTools/GsfTracking/plugins/GsfTrajectoryFitterESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File TrackingTools/GsfTracking/plugins/GsfTrajectorySmootherESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File TrackingTools/TransientTrack/plugins/TransientTrackBuilderESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47191/43439/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47191/43439/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly

cmsbuild · 2025-01-27T21:30:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47191/43440

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoBTag/Combined/src/CandidateChargeBTagComputer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File RecoTracker/TkNavigation/plugins/NavigationSchoolESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File TrackingTools/GsfTools/plugins/CloseComponentsMergerESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File TrackingTools/GsfTools/plugins/DistanceBetweenComponentsESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File TrackingTools/GsfTracking/plugins/GsfTrajectoryFitterESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File TrackingTools/GsfTracking/plugins/GsfTrajectorySmootherESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File TrackingTools/TransientTrack/plugins/TransientTrackBuilderESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2025-01-27T21:31:20Z

Pull request #47191 was updated.

mmusich · 2025-01-27T21:33:04Z

@cmsbuild, please test

cmsbuild · 2025-01-28T23:40:48Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-794d71/44007/summary.html
COMMIT: 095f808
CMSSW: CMSSW_15_0_X_2025-01-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47191/44007/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 4107224
DQMHistoTests: Total failures: 110
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4107094
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 222 log files, 194 edm output root files, 51 DQM output files
TriggerResults: no differences found

mmusich · 2025-01-29T07:10:09Z

+hlt

jfernan2 · 2025-01-29T09:30:44Z

+1

cmsbuild · 2025-01-29T09:31:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-01-30T10:12:06Z

+1

mmusich added 6 commits January 22, 2025 10:27

provide a fillDescriptions for {Global}DetLayerGeometryESProducer

b3ca4d6

add fillDescriptions for NavigationSchoolESProducer

e73af69

let TransientTrackBuilderESProducer auto-generate a cfi file

c15ca11

let GsfTrajectoryFitterESProducer auto-generate a cfi file via fillDe…

f0f1fe4

…scriptions

let GsfTrajectorySmootherESProducer produce an auto-generated cfi file

36ab178

let LXXXCorrectorProducer generate automatically a cfi file

c5e8be3

cmsbuild added this to the CMSSW_15_0_X milestone Jan 27, 2025

cmsbuild added reconstruction-pending analysis-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Jan 27, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 27, 2025

mmusich force-pushed the mm_fillDesc_migration_v6 branch from d09b32f to 3175603 Compare January 27, 2025 21:27

cmsbuild added alca-pending code-checks-pending and removed code-checks-rejected labels Jan 27, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 27, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 27, 2025

add a fillDescriptions to CorrectedJetProducer

f43503e

cmsbuild added tests-started and removed tests-pending labels Jan 28, 2025

cmsbuild added tests-approved and removed tests-started labels Jan 28, 2025

cmsbuild added hlt-approved and removed hlt-pending labels Jan 29, 2025

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Jan 29, 2025

cmsbuild mentioned this pull request Jan 29, 2025

CA Extension to strips #47090

Closed

smuzaffar mentioned this pull request Jan 30, 2025

spurious differences in outputs of Run-3 wfs *.7 #39803

Open

cmsbuild added orp-approved and removed orp-pending labels Jan 30, 2025

cmsbuild merged commit 502e64b into cms-sw:master Jan 30, 2025
11 checks passed

mmusich deleted the mm_fillDesc_migration_v6 branch January 30, 2025 10:14

This was referenced Jan 31, 2025

add fillDescriptions to several plugins used at HLT (5/N) #47224

Merged

Modules not auto-generating a cfi file in cfi-python currently present in the HLT menu (Run 3 and Phase 2) #47275

Open

SWuchterl mentioned this pull request Mar 5, 2025

add fillDescriptions to several BTV plugins used at HLT #47513

Merged

slava77 mentioned this pull request Jul 29, 2025

implement complete/functional fillDescriptions for templated b-taggers and those using common trackSelection #29265

Open

mmusich mentioned this pull request Sep 8, 2025

add fillDescriptions to several plugins used at HLT (6/N) #48858

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add `fillDescriptions` to several `ESproducer`s used at HLT (2/N) #47191

add `fillDescriptions` to several `ESproducer`s used at HLT (2/N) #47191

Uh oh!

mmusich commented Jan 27, 2025 •

edited

Loading

Uh oh!

cmsbuild commented Jan 27, 2025 •

edited

Loading

Uh oh!

cmsbuild commented Jan 27, 2025

Uh oh!

cmsbuild commented Jan 27, 2025

Uh oh!

cmsbuild commented Jan 27, 2025

Uh oh!

mmusich commented Jan 27, 2025

Uh oh!

cmsbuild commented Jan 28, 2025

Uh oh!

mmusich commented Jan 29, 2025

Uh oh!

jfernan2 commented Jan 29, 2025

Uh oh!

cmsbuild commented Jan 29, 2025

Uh oh!

mandrenguyen commented Jan 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

add fillDescriptions to several ESproducers used at HLT (2/N) #47191

add fillDescriptions to several ESproducers used at HLT (2/N) #47191

Uh oh!

Conversation

mmusich commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 27, 2025

Uh oh!

cmsbuild commented Jan 27, 2025

Uh oh!

cmsbuild commented Jan 27, 2025

Uh oh!

mmusich commented Jan 27, 2025

Uh oh!

cmsbuild commented Jan 28, 2025

Comparison Summary

Uh oh!

mmusich commented Jan 29, 2025

Uh oh!

jfernan2 commented Jan 29, 2025

Uh oh!

cmsbuild commented Jan 29, 2025

Uh oh!

mandrenguyen commented Jan 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

add `fillDescriptions` to several `ESproducer`s used at HLT (2/N) #47191

add `fillDescriptions` to several `ESproducer`s used at HLT (2/N) #47191

mmusich commented Jan 27, 2025 •

edited

Loading

cmsbuild commented Jan 27, 2025 •

edited

Loading