Skip to content

Add export to 'create_listener'#153

Merged
juanlofer-eprosima merged 1 commit into
mainfrom
fix_enabler_export
Jul 15, 2025
Merged

Add export to 'create_listener'#153
juanlofer-eprosima merged 1 commit into
mainfrom
fix_enabler_export

Conversation

@cferreiragonz

Copy link
Copy Markdown
Contributor

This PR adds a missing export to the create_listener method to fix compilation on Windows in products inheriting from DynTypesParticipant.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

@juanlofer-eprosima juanlofer-eprosima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Jul 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 37.95%. Comparing base (ee0e639) to head (70d4fff).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
.../participant/dynamic_types/DynTypesParticipant.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   36.50%   37.95%   +1.44%     
==========================================
  Files         171      153      -18     
  Lines       11669     7017    -4652     
  Branches     5347     2788    -2559     
==========================================
- Hits         4260     2663    -1597     
+ Misses       4649     2952    -1697     
+ Partials     2760     1402    -1358     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juanlofer-eprosima
juanlofer-eprosima merged commit 4fde39f into main Jul 15, 2025
15 checks passed
@juanlofer-eprosima
juanlofer-eprosima deleted the fix_enabler_export branch July 15, 2025 08:02
@cferreiragonz

Copy link
Copy Markdown
Contributor Author

@Mergifyio backport 0.x

@mergify

mergify Bot commented Jul 16, 2025

Copy link
Copy Markdown

backport 0.x

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Jul 16, 2025
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 4fde39f)

# Conflicts:
#	ddspipe_participants/include/ddspipe_participants/participant/dynamic_types/DynTypesParticipant.hpp
juanlofer-eprosima pushed a commit that referenced this pull request Jul 16, 2025
* Add export to 'create_listener' (#153)

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 4fde39f)

# Conflicts:
#	ddspipe_participants/include/ddspipe_participants/participant/dynamic_types/DynTypesParticipant.hpp

* Solve conflicts

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants