Skip to content

Add export to 'create_listener' (backport #153)#155

Merged
juanlofer-eprosima merged 2 commits into
0.xfrom
mergify/bp/0.x/pr-153
Jul 16, 2025
Merged

Add export to 'create_listener' (backport #153)#155
juanlofer-eprosima merged 2 commits into
0.xfrom
mergify/bp/0.x/pr-153

Conversation

@mergify

@mergify mergify Bot commented Jul 16, 2025

Copy link
Copy Markdown

This PR adds a missing export to the create_listener method to fix compilation on Windows in products inheriting from DynTypesParticipant.


This is an automatic backport of pull request #153 done by Mergify.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 4fde39f)

# Conflicts:
#	ddspipe_participants/include/ddspipe_participants/participant/dynamic_types/DynTypesParticipant.hpp
@mergify mergify Bot added the conflicts label Jul 16, 2025
@mergify

mergify Bot commented Jul 16, 2025

Copy link
Copy Markdown
Author

Cherry-pick of 4fde39f has failed:

On branch mergify/bp/0.x/pr-153
Your branch is up to date with 'origin/0.x'.

You are currently cherry-picking commit 4fde39f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ddspipe_participants/src/cpp/participant/dynamic_types/DynTypesParticipant.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ddspipe_participants/include/ddspipe_participants/participant/dynamic_types/DynTypesParticipant.hpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (0.x@edde48f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../participant/dynamic_types/DynTypesParticipant.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             0.x     #155   +/-   ##
======================================
  Coverage       ?   34.12%           
======================================
  Files          ?      154           
  Lines          ?     7900           
  Branches       ?     3517           
======================================
  Hits           ?     2696           
  Misses         ?     3280           
  Partials       ?     1924           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juanlofer-eprosima juanlofer-eprosima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima
juanlofer-eprosima merged commit 748f67a into 0.x Jul 16, 2025
15 of 17 checks passed
@juanlofer-eprosima
juanlofer-eprosima deleted the mergify/bp/0.x/pr-153 branch July 16, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants