Prepare for Jazzy upgrade: Improve .docker/Dockerfile to only create users if not already present #9
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good idea. We're not yet ready to upgrade to jazzy, but the $UID:$GID change is still useful for humble. Maybe you would like to alter this PR to not yet reference jazzy. We'll upgrade to jazzy in coordination with libfranka and frank_ros2. Thank you for the PR anyway. |
Author
|
Hi @Smith-JackSmith . I've "downgraded" to humble as requested. I've tested this configuration with ./scripts/visualize_franka.sh arm_id:=fr3with the pass criterion that RViz is shown and the robot is displayed correctly. |
ulikoehler
changed the title
ulikoehler
changed the title
ulikoehler
commented
Feb 12, 2025
Author
ulikoehler
left a comment
ulikoehler
left a comment
There was a problem hiding this comment.
Fix jazzy packages, use humble
ulikoehler
commented
Feb 12, 2025
Author
|
@AndreasKuhner Should be fixed now ! |
|
This is what I had in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of minor changes to the Dockerfile allows using visualize_franka.sh with Jazzy, to avoid incompabitilies in a Jazzy-based setup.
Jazzy has UID/GID 1000 already used by the
ubuntuuser, so I implemented a use existing group or create new group logic, same for the UID. For details, seehttps://techoverflow.net/2025/01/12/shell-logic-how-to-create-user-group-if-no-user-group-with-that-uid-gid-exists/
I only tested scripts/visualize_franka.sh, and only with
arm_id:=fr3. All tests were performed with UID=1000 & GID=1000 on Ubuntu 24.04.