Skip to content

Remove major version from package name#513

Merged
scpeters merged 1 commit intomainfrom
scpeters/package_name_without_major_version_sensors
Apr 3, 2025
Merged

Remove major version from package name#513
scpeters merged 1 commit intomainfrom
scpeters/package_name_without_major_version_sensors

Conversation

@scpeters
Copy link
Copy Markdown
Member

@scpeters scpeters commented Apr 2, 2025

🎉 New feature

Part of gazebo-tooling/release-tools#1244.

Summary

This removes the major version from the package
name in the following places:

  • cmake project name and corresponding find_package calls in examples
  • package.xml name

This does not require any downstream changes, because this version of the package is not yet used in Jetty.

Test it

  1. Build and install this branch.
  2. Build cmake examples.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This removes the major version from the package
name in the following places:

* cmake project name and corresponding find_package
  calls in examples
* package.xml name

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Apr 3, 2025
@scpeters scpeters merged commit 67f362d into main Apr 3, 2025
11 checks passed
@scpeters scpeters deleted the scpeters/package_name_without_major_version_sensors branch April 3, 2025 17:22
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Apr 3, 2025
scpeters added a commit to gazebo-release/gz-sensors10-release that referenced this pull request Apr 15, 2025
Follow-up to gazebosim/gz-sensors#513.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants