Clarify min and max temperature of thermal camera#523
Clarify min and max temperature of thermal camera#523iche033 merged 1 commit intogazebosim:gz-sensors8from
Conversation
Signed-off-by: Marcel Jacobse <44684927+mjacobse@users.noreply.github.com>
|
great thanks for improving the documentation! |
|
Would it be possible to port this to other release versions too? I see that https://gazebosim.org/api/sensors/8/thermalcameraigngazebo.html has the updated description, but https://gazebosim.org/api/sensors/9/thermalcameraigngazebo.html and https://gazebosim.org/api/sensors/6/thermalcameraigngazebo.html (which comes up for me when I google "gazebo thermal camera") still have the old one. |
|
@Mergifyio backport ign-sensors6 |
✅ Backports have been createdDetails
|
Signed-off-by: Marcel Jacobse <44684927+mjacobse@users.noreply.github.com> (cherry picked from commit 67f492a)
Signed-off-by: Marcel Jacobse <44684927+mjacobse@users.noreply.github.com> (cherry picked from commit 67f492a)
ported changes to ign-sensors6 and gz-sensors9 |
This is an attempt to improve the documentation of the
<min_temp>,<max_temp>and<resolution>tags in the thermal camera documentation.After reading the description of
<min_temp>and<max_temp>in the thermal camera tutorial I expected an output camera image value of0to mean<min_temp>Kelvin and a value of2^bitDepth - 1to mean<max_temp>Kelvin, so I was surprised to find out that that was not the case. Granted, the presence of the<resolution>tag did not really fit this mental model. It is also possible that this confusion was amplified by bugs that are now fixed (gazebosim/gz-rendering#1133 and gazebosim/gz-rendering#1138).Nevertheless I tried to rephrase the descriptions a bit in an attempt to minimize the potential for confusion in the future. Hopefully it makes some sense to people other than me.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.