Skip to content

Clarify min and max temperature of thermal camera#523

Merged
iche033 merged 1 commit intogazebosim:gz-sensors8from
mjacobse:clarify_min_max_temp_camera
May 14, 2025
Merged

Clarify min and max temperature of thermal camera#523
iche033 merged 1 commit intogazebosim:gz-sensors8from
mjacobse:clarify_min_max_temp_camera

Conversation

@mjacobse
Copy link
Copy Markdown
Contributor

This is an attempt to improve the documentation of the <min_temp>, <max_temp> and <resolution> tags in the thermal camera documentation.

After reading the description of <min_temp> and <max_temp> in the thermal camera tutorial I expected an output camera image value of 0 to mean <min_temp> Kelvin and a value of 2^bitDepth - 1 to mean <max_temp> Kelvin, so I was surprised to find out that that was not the case. Granted, the presence of the <resolution> tag did not really fit this mental model. It is also possible that this confusion was amplified by bugs that are now fixed (gazebosim/gz-rendering#1133 and gazebosim/gz-rendering#1138).

Nevertheless I tried to rephrase the descriptions a bit in an attempt to minimize the potential for confusion in the future. Hopefully it makes some sense to people other than me.

Checklist

  • Signed all commits for DCO
  • Updated documentation (as needed)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Marcel Jacobse <44684927+mjacobse@users.noreply.github.com>
@mjacobse mjacobse requested a review from iche033 as a code owner May 14, 2025 09:15
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 14, 2025
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 14, 2025
@iche033
Copy link
Copy Markdown
Contributor

iche033 commented May 14, 2025

great thanks for improving the documentation!

@iche033 iche033 enabled auto-merge (squash) May 14, 2025 22:28
@iche033 iche033 merged commit 67f492a into gazebosim:gz-sensors8 May 14, 2025
10 of 11 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 14, 2025
@mjacobse mjacobse deleted the clarify_min_max_temp_camera branch May 15, 2025 06:46
@mjacobse
Copy link
Copy Markdown
Contributor Author

Would it be possible to port this to other release versions too? I see that https://gazebosim.org/api/sensors/8/thermalcameraigngazebo.html has the updated description, but https://gazebosim.org/api/sensors/9/thermalcameraigngazebo.html and https://gazebosim.org/api/sensors/6/thermalcameraigngazebo.html (which comes up for me when I google "gazebo thermal camera") still have the old one.

@iche033
Copy link
Copy Markdown
Contributor

iche033 commented Jul 10, 2025

@Mergifyio backport ign-sensors6

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 10, 2025

backport ign-sensors6

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jul 10, 2025
Signed-off-by: Marcel Jacobse <44684927+mjacobse@users.noreply.github.com>
(cherry picked from commit 67f492a)
iche033 pushed a commit that referenced this pull request Jul 10, 2025
Signed-off-by: Marcel Jacobse <44684927+mjacobse@users.noreply.github.com>
(cherry picked from commit 67f492a)
@iche033
Copy link
Copy Markdown
Contributor

iche033 commented Jul 10, 2025

Would it be possible to port this to other release versions too? I see that https://gazebosim.org/api/sensors/8/thermalcameraigngazebo.html has the updated description, but https://gazebosim.org/api/sensors/9/thermalcameraigngazebo.html and https://gazebosim.org/api/sensors/6/thermalcameraigngazebo.html (which comes up for me when I google "gazebo thermal camera") still have the old one.

ported changes to ign-sensors6 and gz-sensors9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants