Clarify min and max temperature of thermal camera (backport #523)#539
Merged
iche033 merged 1 commit intoign-sensors6from Jul 10, 2025
Merged
Clarify min and max temperature of thermal camera (backport #523)#539iche033 merged 1 commit intoign-sensors6from
iche033 merged 1 commit intoign-sensors6from
Conversation
Signed-off-by: Marcel Jacobse <44684927+mjacobse@users.noreply.github.com> (cherry picked from commit 67f492a)
2 tasks
iche033
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to improve the documentation of the
<min_temp>,<max_temp>and<resolution>tags in the thermal camera documentation.After reading the description of
<min_temp>and<max_temp>in the thermal camera tutorial I expected an output camera image value of0to mean<min_temp>Kelvin and a value of2^bitDepth - 1to mean<max_temp>Kelvin, so I was surprised to find out that that was not the case. Granted, the presence of the<resolution>tag did not really fit this mental model. It is also possible that this confusion was amplified by bugs that are now fixed (gazebosim/gz-rendering#1133 and gazebosim/gz-rendering#1138).Nevertheless I tried to rephrase the descriptions a bit in an attempt to minimize the potential for confusion in the future. Hopefully it makes some sense to people other than me.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.This is an automatic backport of pull request #523 done by Mergify.