Skip to content

Clarify min and max temperature of thermal camera (backport #523)#539

Merged
iche033 merged 1 commit intoign-sensors6from
mergify/bp/ign-sensors6/pr-523
Jul 10, 2025
Merged

Clarify min and max temperature of thermal camera (backport #523)#539
iche033 merged 1 commit intoign-sensors6from
mergify/bp/ign-sensors6/pr-523

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jul 10, 2025

This is an attempt to improve the documentation of the <min_temp>, <max_temp> and <resolution> tags in the thermal camera documentation.

After reading the description of <min_temp> and <max_temp> in the thermal camera tutorial I expected an output camera image value of 0 to mean <min_temp> Kelvin and a value of 2^bitDepth - 1 to mean <max_temp> Kelvin, so I was surprised to find out that that was not the case. Granted, the presence of the <resolution> tag did not really fit this mental model. It is also possible that this confusion was amplified by bugs that are now fixed (gazebosim/gz-rendering#1133 and gazebosim/gz-rendering#1138).

Nevertheless I tried to rephrase the descriptions a bit in an attempt to minimize the potential for confusion in the future. Hopefully it makes some sense to people other than me.

Checklist

  • Signed all commits for DCO
  • Updated documentation (as needed)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #523 done by Mergify.

Signed-off-by: Marcel Jacobse <44684927+mjacobse@users.noreply.github.com>
(cherry picked from commit 67f492a)
@mergify mergify bot requested a review from iche033 as a code owner July 10, 2025 18:15
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 10, 2025
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jul 10, 2025
@iche033 iche033 merged commit 8188953 into ign-sensors6 Jul 10, 2025
11 checks passed
@iche033 iche033 deleted the mergify/bp/ign-sensors6/pr-523 branch July 10, 2025 20:24
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants