Skip to content

[Bazel] Update bazel module to use jetty release branches#551

Merged
iche033 merged 2 commits intogz-sensors10from
iche033/bazel_mod_jetty
Aug 28, 2025
Merged

[Bazel] Update bazel module to use jetty release branches#551
iche033 merged 2 commits intogz-sensors10from
iche033/bazel_mod_jetty

Conversation

@iche033
Copy link
Copy Markdown
Contributor

@iche033 iche033 commented Aug 27, 2025

🦟 Bug fix

Summary

Change main to jetty release branches

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
Copy link
Copy Markdown
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not great that we have another place to maintain these branch names. It would be nice if we can automate this somehow to pull from gazebodistro. Maybe a script in release-tools to update these files?

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Aug 28, 2025
@scpeters
Copy link
Copy Markdown
Member

It's not great that we have another place to maintain these branch names. It would be nice if we can automate this somehow to pull from gazebodistro. Maybe a script in release-tools to update these files?

this is a big topic, perhaps move to an issue or the infra slack?

@iche033
Copy link
Copy Markdown
Contributor Author

iche033 commented Aug 28, 2025

It's not great that we have another place to maintain these branch names. It would be nice if we can automate this somehow to pull from gazebodistro. Maybe a script in release-tools to update these files?

this is a big topic, perhaps move to an issue or the infra slack?

I ticketed an issue for this: gazebo-tooling/release-tools#1386

@azeey
Copy link
Copy Markdown
Contributor

azeey commented Aug 28, 2025

Yes, I agree it's a bigger topic. Thanks for creating the release-tools issue!

@iche033
Copy link
Copy Markdown
Contributor Author

iche033 commented Aug 28, 2025

ok merging this PR first.

@iche033 iche033 merged commit b595bad into gz-sensors10 Aug 28, 2025
13 checks passed
@iche033 iche033 deleted the iche033/bazel_mod_jetty branch August 28, 2025 20:11
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Aug 28, 2025
@iche033 iche033 mentioned this pull request Sep 26, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants