Skip to content

Add Action InputName for BaseButton to deprecate TouchScreenButton. - #120693

Open
Kazox61 wants to merge 1 commit into
godotengine:masterfrom
Kazox61:deprecate-touch_screen_button
Open

Add Action InputName for BaseButton to deprecate TouchScreenButton.#120693
Kazox61 wants to merge 1 commit into
godotengine:masterfrom
Kazox61:deprecate-touch_screen_button

Conversation

@Kazox61

@Kazox61 Kazox61 commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

What problem(s) does this PR solve?

Additional information

The Multitouch Support for BaseButton #110893 was the first step to depreciate the TouchScreenButton. This is a follow up PR to implement the remaining Action InputName to include all features from TouchScreenButton into the BaseButton.

@Kazox61
Kazox61 requested review from a team as code owners June 27, 2026 16:12
@Nintorch Nintorch added this to the 4.x milestone Jun 28, 2026
@Nintorch
Nintorch requested a review from a team June 28, 2026 06:55

@Nintorch Nintorch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my Android phone, it works as expected!
The input action also gets activated by clicking on the button with a mouse if emulating touch from mouse is disabled (which doesn't work in TouchScreenButton), which, I think, is also expected.

Screenrecorder-2026-06-30-19-59-50-78.mp4

TestProject.zip

Comment thread doc/classes/BaseButton.xml Outdated
@Nintorch
Nintorch requested a review from Alex2782 June 30, 2026 15:11
Comment thread doc/classes/TouchScreenButton.xml
@Kazox61
Kazox61 force-pushed the deprecate-touch_screen_button branch 2 times, most recently from b8bb245 to 69101b4 Compare June 30, 2026 16:06

@Calinou Calinou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is unrelated to the changes:

Add Resolution Presets for the embedded game window

@Kazox61
Kazox61 force-pushed the deprecate-touch_screen_button branch from 69101b4 to d4e9d92 Compare July 2, 2026 15:00
@Kazox61

Kazox61 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement multitouch in BaseButton to supersede TouchScreenButton

3 participants