[C#] Change generated On{SignalName} to EmitSignal{SignalName}

[TML233]

Change the generated On{SignalName}, which is introduced in #68233 , to EmitSignal{SignalName}
Editor already generates _on_{signal_name} for signal callbacks.
Having On{SignalName} introduces confusion and will likely break user code, since Godot users are already familiar with on signal name for signal callback functions.

Using EmitSignal{SignalName} conforms to Godot's name of raising signals emit_signal.
The terms and names are consistent between defining signals (using [Signal] attribute) and emitting signals (using EmitSignalName methods). Also it kinda looks great in the intellisense list, like:

• EmitSignal (Godot's original emit_signal)
• EmitSignalPressed
• EmitSignalChanged

[Delsin-Yu]

Although I'm not entirely sure of the Emit{SignalName} naming scheme, but I do agree that we should not use the On{SignalName}, as I mentioned in the original PR that On{SignalName} is used for referring Callee, not the Caller in guidelines.
Reference: .Net Guidlines.

[pmoosi]

According to the guidelines it should be On.... It's confusingly worded there, but on the events page is an example.

However, I think it's still worth considering if all the C# event guidelines should be followed as strictly. For me signals are not exactly the same as C# events. So using 'emit' instead of 'on' might be more in line with the Godot naming.

[Delsin-Yu]

Oh... emit collides with Resource::emit_changed, so that's blocked.

[Delsin-Yu]

Or we just tread that emit_signal as a special, already implemented case and do not generate the corresponding wrapper method of it.

[TML233]

Or we just tread that emit_signal as a special, already implemented case and do not generate the corresponding wrapper method of it.

I don't think it's appropriate. Resource::emit_changed has extra logic to notify ResourceLoader. We need to generate another method to just do emit_signal("changed")

[TML233]

EmitSignal{SignalName} seemed a good choice.

[scgm0]

@raulsntos Can you check this PR? EmitSignal{SignalName} is more suitable for me than On{SignalName}, because I already use On{SignalName} as the signal listening method in my personal project

[scgm0]

This PR could resolve the compatibility issue mentioned in #97781, I honestly don't know why no one has reviewed this PR yet

[raulsntos]

We have discussed this and we think the On{SignalName} conflicts too much with existing projects. As others have mentioned in this thread, our own documentation recommends naming signal callbacks with the On{SignalName} pattern, so the chances to conflict are too high.

Renaming to EmitSignal{SignalName} is a lot less disruptive. We think we should avoid breaking existing user projects unnecessarily, so we're approving this change. Thanks for the contribution!

[Repiteo]

Thanks!