Form: refactor section config in RDMDepositForm #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0einstein0
force-pushed
the
curation-checks
branch
3 times, most recently
from
19efcc4 to
dac903c
Compare
0einstein0
changed the title
0einstein0
force-pushed
the
curation-checks
branch
2 times, most recently
from
6e07166 to
124d1a1
Compare
10 tasks
0einstein0
force-pushed
the
curation-checks
branch
from
124d1a1 to
b9b1bba
Compare
Co-authored-by: Carlin Mackenzie <[email protected]>
0einstein0
force-pushed
the
curation-checks
branch
from
b9b1bba to
8736489
Compare
0einstein0
force-pushed
the
curation-checks
branch
4 times, most recently
from
5280a98 to
6fe8b93
Compare
0einstein0
reviewed
Mar 14, 2025
0einstein0
reviewed
Mar 14, 2025
invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/RDMDepositForm.js
Show resolved
Hide resolved
0einstein0
reviewed
Mar 14, 2025
There was a problem hiding this comment.
Remember to ignore whitespaces
0einstein0
force-pushed
the
curation-checks
branch
from
6fe8b93 to
be24f9c
Compare
0einstein0
force-pushed
the
curation-checks
branch
from
be24f9c to
ae52a28
Compare
kpsherva
reviewed
Mar 17, 2025
| // Adding section id to custom fields UI, to be used for accordions | ||
| const customFieldsUI = this.config.custom_fields.ui.map((section) => ({ | ||
| ...section, | ||
| id: section.section.toLowerCase().replace(/\s+/g, "-") + "-section", |
There was a problem hiding this comment.
the regex detection is quite risky, why is it needed?
There was a problem hiding this comment.
the section names are defined like this for example in the ui config, so it is replacing space with - and appending -section
kpsherva
reviewed
Mar 17, 2025
invenio_app_rdm/theme/assets/semantic-ui/less/invenio_app_rdm/theme/collections/form.overrides
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: