Skip to content

feat(FR-2631): implement STokenLoginBoundary component core#6853

Merged
graphite-app[bot] merged 1 commit into
mainfrom
04-21-feat_fr-2631_implement_stokenloginboundary_component_core
Apr 23, 2026
Merged

feat(FR-2631): implement STokenLoginBoundary component core#6853
graphite-app[bot] merged 1 commit into
mainfrom
04-21-feat_fr-2631_implement_stokenloginboundary_component_core

Conversation

@nowgnuesLee
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee commented Apr 21, 2026

Resolves FR-2631 (sub-task of Epic FR-2616)

resolves #NNN (FR-MMM)

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Stack

This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the dev plan for the full scope. The Story 1 PR stack is #6850#6851#6852#6853#6854#6855#6856 on top of spec PR #6828.

Copy link
Copy Markdown
Contributor Author

nowgnuesLee commented Apr 21, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
8.56% (-0.02% 🔻)
1758/20539
🔴 Branches
7.84% (-0.02% 🔻)
1131/14419
🔴 Functions
5.14% (+0.01% 🔼)
286/5561
🔴 Lines
8.28% (-0.02% 🔻)
1650/19928
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / STokenLoginBoundary.tsx
0% 0% 0% 0%

Test suite run success

856 tests passing in 39 suites.

Report generated by 🧪jest coverage report action from d1c71fe

@nowgnuesLee nowgnuesLee force-pushed the 04-21-feat_fr-2631_implement_stokenloginboundary_component_core branch 2 times, most recently from 082b3a1 to cc085c9 Compare April 22, 2026 02:38
@nowgnuesLee nowgnuesLee force-pushed the 04-21-feat_fr-2631_implement_stokenloginboundary_component_core branch 2 times, most recently from 0737f09 to 8b0c4ca Compare April 22, 2026 03:53
@nowgnuesLee nowgnuesLee force-pushed the 04-21-feat_fr-2630_add_usestoken_hook_with_nuqs_and_stoken_deprecation_warning branch from 741c222 to 68fc2d7 Compare April 22, 2026 03:53
@nowgnuesLee nowgnuesLee marked this pull request as ready for review April 23, 2026 06:09
Copilot AI review requested due to automatic review settings April 23, 2026 06:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements the initial core of a reusable STokenLoginBoundary component to encapsulate the sToken-based login sequence (endpoint resolve → ping → token_login → GQL connect) and gate rendering of children until authentication succeeds.

Changes:

  • Added STokenLoginBoundary / STokenLoginBoundaryInner with a small phase state machine (pending/success/error) and a retry mechanism.
  • Implemented the login sequence (server reachability check, optional session fast-path, token login + GQL wiring) and dispatches a backend-ai-connected event on success.
  • Added placeholder fallback and error UI for pending/error phases.

Comment thread react/src/components/STokenLoginBoundary.tsx
Comment thread react/src/components/STokenLoginBoundary.tsx
Comment thread react/src/components/STokenLoginBoundary.tsx Outdated
Comment thread react/src/components/STokenLoginBoundary.tsx
Comment thread react/src/components/STokenLoginBoundary.tsx
@nowgnuesLee nowgnuesLee force-pushed the 04-21-feat_fr-2631_implement_stokenloginboundary_component_core branch from 8b0c4ca to ddc7039 Compare April 23, 2026 07:57
@nowgnuesLee nowgnuesLee force-pushed the 04-21-feat_fr-2630_add_usestoken_hook_with_nuqs_and_stoken_deprecation_warning branch 2 times, most recently from 61a25de to f6760d3 Compare April 23, 2026 08:02
@nowgnuesLee nowgnuesLee force-pushed the 04-21-feat_fr-2631_implement_stokenloginboundary_component_core branch from ddc7039 to 42656be Compare April 23, 2026 08:02
@nowgnuesLee nowgnuesLee force-pushed the 04-21-feat_fr-2630_add_usestoken_hook_with_nuqs_and_stoken_deprecation_warning branch from f6760d3 to b931e8a Compare April 23, 2026 08:35
@nowgnuesLee nowgnuesLee force-pushed the 04-21-feat_fr-2631_implement_stokenloginboundary_component_core branch from 42656be to 546add2 Compare April 23, 2026 08:35
Copy link
Copy Markdown
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 23, 2026

Merge activity

Resolves FR-2631 (sub-task of Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616))

resolves #NNN (FR-MMM)
<!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. -->

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after

## Stack

This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full scope. The Story 1 PR stack is #6850#6851#6852#6853#6854#6855#6856 on top of spec PR #6828.

[FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app Bot pushed a commit that referenced this pull request Apr 23, 2026
…int (#6850)

Resolves FR-2628 (sub-task of Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616))

resolves #NNN (FR-MMM)
<!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. -->

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after

## Stack

This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full scope. The Story 1 PR stack is #6850#6851#6852#6853#6854#6855#6856 on top of spec PR #6828.

[FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app Bot pushed a commit that referenced this pull request Apr 23, 2026
)

Resolves FR-2629 (sub-task of Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616))

resolves #NNN (FR-MMM)
<!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. -->

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after

## Stack

This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full scope. The Story 1 PR stack is #6850#6851#6852#6853#6854#6855#6856 on top of spec PR #6828.

[FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app Bot pushed a commit that referenced this pull request Apr 23, 2026
…rning (#6852)

Resolves FR-2630 (sub-task of Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616))

resolves #NNN (FR-MMM)
<!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. -->

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after

## Stack

This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full scope. The Story 1 PR stack is #6850#6851#6852#6853#6854#6855#6856 on top of spec PR #6828.

[FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@graphite-app graphite-app Bot force-pushed the 04-21-feat_fr-2630_add_usestoken_hook_with_nuqs_and_stoken_deprecation_warning branch from b931e8a to fa2be96 Compare April 23, 2026 10:34
@graphite-app graphite-app Bot force-pushed the 04-21-feat_fr-2631_implement_stokenloginboundary_component_core branch from 546add2 to d1c71fe Compare April 23, 2026 10:34
graphite-app Bot pushed a commit that referenced this pull request Apr 23, 2026
…Boundary (#6855)

Resolves FR-2632 (sub-task of Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616))

resolves #NNN (FR-MMM)
<!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. -->

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after

## Stack

This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full scope. The Story 1 PR stack is #6850#6851#6852#6853#6854#6855#6856 on top of spec PR #6828.

[FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app Bot pushed a commit that referenced this pull request Apr 23, 2026
Resolves FR-2633 (sub-task of Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616))

resolves #NNN (FR-MMM)
<!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. -->

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after

## Stack

This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full scope. The Story 1 PR stack is #6850#6851#6852#6853#6854#6855#6856 on top of spec PR #6828.

[FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Base automatically changed from 04-21-feat_fr-2630_add_usestoken_hook_with_nuqs_and_stoken_deprecation_warning to main April 23, 2026 10:41
@graphite-app graphite-app Bot merged commit d1c71fe into main Apr 23, 2026
8 checks passed
@graphite-app graphite-app Bot deleted the 04-21-feat_fr-2631_implement_stokenloginboundary_component_core branch April 23, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants