Add load-dependent data-based HP and chiller models#4170
Merged
Conversation
…uildings into issue4152_HpTemplateWithModular
…ssue4169_loadDepHpChillerModels
0e30716 to
02cc25a
Compare
3 tasks
- This is due to an error when reading the reference results. - Removing the data reader makes the models supported by OMC.
- Exclude model from CI tests with OMC.
- The description of the parameters for the design CHW/HW and source temperature has been updated. - The documentation of the core block has been improved. - The parameter P_min is now declared as SI.Power. - The input connector TSet has been moved to avoid overlap with ySet. - The description of the input connectors on, hea and coo has been clarified.
- Replace source by ambient for compatibility with cooling cycles.
JayHuLBL
reviewed
May 30, 2025
JayHuLBL
reviewed
May 30, 2025
JayHuLBL
reviewed
May 30, 2025
JayHuLBL
reviewed
May 30, 2025
Contributor
JayHuLBL
left a comment
There was a problem hiding this comment.
@AntoineGautier Please see the inline comments, which are minor.
Contributor
Author
|
@JayHuLBL Thanks for the review, I've addressed your comments. |
JayHuLBL
approved these changes
Jun 3, 2025
Contributor
Author
mwetter
reviewed
Jun 5, 2025
Contributor
Author
|
@mwetter The user guide is updated via ibpsa/modelica-ibpsa#2025. |
Contributor
Author
|
@mwetter I've made some minor changes in e2cbb7e.
I have no more to add to this PR that can be merged if these changes look good to you. |
Contributor
Author
|
@mwetter This is ready on my end. You can merge it. |
This was referenced Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #4169
This isolates the changes to the packages
Buildings.Fluid.Chillers.ModularReversibleandBuildings.Fluid.HeatPumps.ModularReversible, as these modifications may need to be pushed to the IBPSA Library first.The core algorithm is implemented in the block
Fluid.HeatPumps.ModularReversible.RefrigerantCycle.BaseClasses.TableData2DLoadDep.The new validation models within
Buildings.Fluid.Chillers.ModularReversible.Validationreveal interesting issues with the existing polynomial chiller modelsElectricEIRandElectricReformulatedEIR.The new chiller model
TableData2DLoadDep