Skip to content

Add load-dependent data-based HP and chiller models#4170

Merged
mwetter merged 30 commits intomasterfrom
issue4169_loadDepHpChillerModels
Aug 21, 2025
Merged

Add load-dependent data-based HP and chiller models#4170
mwetter merged 30 commits intomasterfrom
issue4169_loadDepHpChillerModels

Conversation

@AntoineGautier
Copy link
Copy Markdown
Contributor

@AntoineGautier AntoineGautier commented Mar 18, 2025

This addresses #4169

This isolates the changes to the packages Buildings.Fluid.Chillers.ModularReversible and Buildings.Fluid.HeatPumps.ModularReversible, as these modifications may need to be pushed to the IBPSA Library first.

The core algorithm is implemented in the block Fluid.HeatPumps.ModularReversible.RefrigerantCycle.BaseClasses.TableData2DLoadDep.

The new validation models within Buildings.Fluid.Chillers.ModularReversible.Validation reveal interesting issues with the existing polynomial chiller models ElectricEIR and ElectricReformulatedEIR.
The new chiller model TableData2DLoadDep

  • eliminates these issues,
  • shows equivalent accuracy for capacity and power calculation,
  • avoids the burden for users to pre-compute polynomial coefficients from manufacturer data.

- This is due to an error when reading the reference results.
- Removing the data reader makes the models supported by OMC.
- Exclude model from CI tests with OMC.
- The description of the parameters for the design CHW/HW and source temperature has been updated.
- The documentation of the core block has been improved.
- The parameter P_min is now declared as SI.Power.
- The input connector TSet has been moved to avoid overlap with ySet.
- The description of the input connectors on, hea and coo has been
  clarified.
- Replace source by ambient for compatibility with cooling cycles.
@JayHuLBL JayHuLBL self-requested a review May 15, 2025 16:16
Comment thread Buildings/Fluid/Chillers/ModularReversible/Data/TableData2DLoadDep/Generic.mo Outdated
Comment thread Buildings/Fluid/Chillers/ModularReversible/TableData2DLoadDep.mo Outdated
Copy link
Copy Markdown
Contributor

@JayHuLBL JayHuLBL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntoineGautier Please see the inline comments, which are minor.

@AntoineGautier
Copy link
Copy Markdown
Contributor Author

@JayHuLBL Thanks for the review, I've addressed your comments.

@AntoineGautier
Copy link
Copy Markdown
Contributor Author

@mwetter Could you have a final look on this PR? (Note the joint issue #4261 that I've opened to include performance data sets based on the records for the polynomial chiller model.)

Copy link
Copy Markdown
Member

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition. I made minor cosmetic changes. Could you please also

  • Update the library release notes.
  • Mention the new models in the heat pump user guide.
  • Merge changes that would be needed to IBPSA if they affect the existing models.

@AntoineGautier
Copy link
Copy Markdown
Contributor Author

@mwetter The user guide is updated via ibpsa/modelica-ibpsa#2025.

@AntoineGautier
Copy link
Copy Markdown
Contributor Author

AntoineGautier commented Jun 12, 2025

@mwetter I've made some minor changes in e2cbb7e.

  • I've moved the declaration of P_min "Minimum power when system is enabled with compressor cycled off" from the data record to the main model Buildings.Fluid.HeatPumps.ModularReversible.TableData2DLoadDep: this is because this parameter is used as is, and not scaled as other variables computed from the performance data provided via the record. In this respect, it better goes along with the nominal capacity specified in the main model.
  • I've added the declaration of tabNamQ "Table names with heat flow rate data" and tabNamP "Table names with power data" to the data record: this is because these names must match the ones used in the table specified in the data record, so it seems like a good place to specify them. Previously, one could only modify these names by modifying the bindings refCyc.refCycHeaPum*.calQUseP.tabNam* deeply nested in the model composition.

I have no more to add to this PR that can be merged if these changes look good to you.

@AntoineGautier
Copy link
Copy Markdown
Contributor Author

@mwetter This is ready on my end. You can merge it.

@mwetter mwetter merged commit 5015240 into master Aug 21, 2025
3 checks passed
@mwetter mwetter deleted the issue4169_loadDepHpChillerModels branch August 21, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants