Skip to content

feat: make chopper default for longread qc#1059

Open
dialvarezs wants to merge 8 commits into
nf-core:devfrom
dialvarezs:refactor/default-lr-qc-chopper
Open

feat: make chopper default for longread qc#1059
dialvarezs wants to merge 8 commits into
nf-core:devfrom
dialvarezs:refactor/default-lr-qc-chopper

Conversation

@dialvarezs

@dialvarezs dialvarezs commented Jun 25, 2026

Copy link
Copy Markdown
Member
  • Makes chopper the default long read filtering tool instead of filtlong. Chopper does the same job with less overhead; filtlong and nanoq stay available via --longread_filtering_tool.

  • Adds --longread_filtering_by_shortreads (default: false). Before this, filtlong always tried to join short and long reads to derive quality from k-mer matches, which could drop long reads that didn't overlap the short read set. Now that behavior is opt-in.

  • test_hybrid pins --longread_filtering_tool filtlong explicitly since the default changed.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

dialvarezs added a commit to dialvarezs/mag that referenced this pull request Jun 25, 2026
@dialvarezs dialvarezs force-pushed the refactor/default-lr-qc-chopper branch from 306311c to 2a65139 Compare June 25, 2026 16:37
@dialvarezs dialvarezs changed the title refactor: make chopper default for longread qc feat: make chopper default for longread qc Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant