feat: make chopper default for longread qc#1059
Open
dialvarezs wants to merge 8 commits into
Open
Conversation
dialvarezs
added a commit
to dialvarezs/mag
that referenced
this pull request
Jun 25, 2026
306311c to
2a65139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
chopperthe default long read filtering tool instead offiltlong. Chopper does the same job with less overhead;filtlongandnanoqstay available via--longread_filtering_tool.Adds
--longread_filtering_by_shortreads(default:false). Before this, filtlong always tried to join short and long reads to derive quality from k-mer matches, which could drop long reads that didn't overlap the short read set. Now that behavior is opt-in.test_hybridpins--longread_filtering_tool filtlongexplicitly since the default changed.PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).