Implement wave container commands#3954
Conversation
JulianFlesch
changed the title
| ] | ||
| return containers_flat | ||
|
|
||
| def _resolve_module_dir(self, module: str | Path) -> Path: |
There was a problem hiding this comment.
do we not have this funciton already somehwere else?
There was a problem hiding this comment.
I might be overlooking something, but not really ... As far as I can tell, we have ModulesInfo, which was used at some point, but it never provides the environment.yml or meta.yml paths, or confirms their existance.
Maybe this should be in ModulesInfo?
| return module_dir | ||
|
|
||
| @staticmethod | ||
| def _environment_path(module_dir: Path) -> Path: |
There was a problem hiding this comment.
because we lint for this, I think we should be able to reuse something there.
|
|
||
|
|
||
| @contextmanager | ||
| def set_wd_tempdir() -> Generator[None, None, None]: |
There was a problem hiding this comment.
this function is for sure created somewhere else already.
There was a problem hiding this comment.
Yes, In pipeline downloads! But that version throws Download-specific errors ...
The plan was move it out of the utils.py over there into the general utils.
But now we don't use it at all anymore ...
Should we remove it again?
|
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Added the meta_yml sorting now. I also switched the default value of |
mashehu
force-pushed
the
feature/3952-create-waveyml
branch
from
1de5380 to
b92491a
Compare
|
|
||
| # Load containers from meta.yml into the component before linting | ||
| meta_path = Path(self.nfcore_component.component_dir, "meta.yml") | ||
| if meta_path.exists(): |
There was a problem hiding this comment.
no need for this if clause, we already check that in read_meta_yml()
mashehu
force-pushed
the
feature/3952-create-waveyml
branch
3 times, most recently
from
47ed327 to
b71b250
Compare
# Conflicts: # tests/modules/test_containers.py
…ain on the new version.
via `nf-core m container create multiqc` from nf-core/tools#3954
via `nf-core m container create multiqc` from nf-core/tools#3954
* pin build version for multiqc * fix singularity urls * update seqera container via `nf-core m container create multiqc` from nf-core/tools#3954 --------- Co-authored-by: mashehu <mashehu3@gmail.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
3 participants
Closes #3952