Transforms: share the view/permute algebra with all backends - #22119
Open
rascani wants to merge 2 commits into
Open
Transforms: share the view/permute algebra with all backends#22119rascani wants to merge 2 commits into
rascani wants to merge 2 commits into
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22119
Note: Links to docs will display an error until the docs builds have been completed. ❌ 43 New Failures, 2 Cancelled JobsAs of commit 0b038a5 with merge base e831b3e ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dim_maps holds the algebra that permute-fusing passes use to decide whether a
reshape can be commuted past a transpose, and whether two data-movement ops
cancel. It is the piece a backend cannot reasonably reimplement, and today it
is only reachable by depending on the Arm backend.
Nothing in it is Arm-specific: 1030 lines importing sympy, torch and
exir.dialects, with no reference to TOSA, Ethos or any Arm pass. Move it to
backends/transforms so that op-level backends -- Cortex-M first -- can build on
the same layout optimization infrastructure rather than growing a parallel copy.
A re-export shim stays at the old path forwarding every symbol other modules
import, including the underscore-prefixed helpers, so in-flight Arm work is
unaffected and its 746-line test suite runs unchanged against the moved module.
This also resolves a latent build problem it was tangled in. The Arm :core
target lists arm_pass_utils.py in explicit srcs, and that file imports dim_maps,
which was globbed into :passes -- while :passes depends on :core. The dependency
could not be declared without a cycle. dim_maps now has its own target below
both, so the edge is expressible.
No behaviour change; the module is byte-identical apart from its path.
Authored with Claude Code.