Transforms: share the view/permute canonicalizer - #22121
Open
rascani wants to merge 2 commits into
Open
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22121
Note: Links to docs will display an error until the docs builds have been completed. ❌ 43 New Failures, 1 Unrelated FailureAs of commit ebda719 with merge base e831b3e ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CanonicalizeViewCopyPermutePass is the pass that decides when a reshape and a
transpose can be rewritten into each other, and turns a data-movement-free
permute into a view. It is the capability that lets a permute cross a
rank-changing view instead of stopping there, and no shared pass has an
equivalent.
Move it to backends/transforms, along with refresh_permute_view_meta, the
SymInt-preserving meta recomputation it needs. Neither had any real tie to Arm:
the pass used ArmPass purely as an ExportPass -- it references none of
allowed_to_transform, is_tfa_pass, submodule_depth or target_ops -- and the
helper only touches aten view and permute. Both now derive from and import the
neutral equivalents, with re-export shims at the old paths.
The one TOSA-flavoured detail was a comment claiming dynamic views are
unsupported by TOSA where the code simply requires static shapes; reworded to
say what the check does.
No behaviour change: the Arm pass suite produces a failure set identical to
merge base, name for name.
Authored with Claude Code.