Skip to content

Transforms: share the view/permute canonicalizer - #22121

Open
rascani wants to merge 2 commits into
gh/rascani/24/headfrom
gh/rascani/25/head
Open

Transforms: share the view/permute canonicalizer#22121
rascani wants to merge 2 commits into
gh/rascani/24/headfrom
gh/rascani/25/head

Conversation

@rascani

@rascani rascani commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

CanonicalizeViewCopyPermutePass is the pass that decides when a reshape and a
transpose can be rewritten into each other, and turns a data-movement-free
permute into a view. It is the capability that lets a permute cross a
rank-changing view instead of stopping there, and no shared pass has an
equivalent.

Move it to backends/transforms, along with refresh_permute_view_meta, the
SymInt-preserving meta recomputation it needs. Neither had any real tie to Arm:
the pass used ArmPass purely as an ExportPass -- it references none of
allowed_to_transform, is_tfa_pass, submodule_depth or target_ops -- and the
helper only touches aten view and permute. Both now derive from and import the
neutral equivalents, with re-export shims at the old paths.

The one TOSA-flavoured detail was a comment claiming dynamic views are
unsupported by TOSA where the code simply requires static shapes; reworded to
say what the check does.

No behaviour change: the Arm pass suite produces a failure set identical to
merge base, name for name.

Authored with Claude Code.

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22121

Note: Links to docs will display an error until the docs builds have been completed.

❌ 43 New Failures, 1 Unrelated Failure

As of commit ebda719 with merge base e831b3e (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant