Arm backend: give the propagation pass backend extension points - #22120
Open
rascani wants to merge 2 commits into
Open
Arm backend: give the propagation pass backend extension points#22120rascani wants to merge 2 commits into
rascani wants to merge 2 commits into
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22120
Note: Links to docs will display an error until the docs builds have been completed. ❌ 43 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit 594713f with merge base e831b3e ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PropagateViewCopyPermute is the strongest permute/view mover in the tree, but it
can only be used by Arm: the algorithm reaches directly for tosa.RESCALE,
tosa.TABLE and tosa.SCATTER, for a TOSA compile spec, and for the TOSA fusion
pass. None of that is essential to what it does.
Replace those references with questions the algorithm asks, and answer them in a
TosaPropagationOverrides mixin that the Up and Down passes inherit. The
questions are phrased in terms of the property the algorithm needs rather than
the operator that happens to have it: whether a node is transparent to data
movement, whether an elementwise op has non-layout-carrying extra inputs,
whether a user must not be crossed, whether propagation should run at all, and
which region-cancellation engine to fuse with.
Backends other than Arm can now derive and answer these for themselves. Nothing
is parameterized on Arm's answers -- the base defaults are the neutral ones, and
the TOSA specifics, including the Ethos-U85 gate and the per-tensor rescale
check, live entirely in the mixin.
No behaviour change: the Arm pass suite produces a failure set identical to
merge base (33 pre-existing failures here, all from the absent VGF compiler).
Authored with Claude Code.