Transforms: share the permute/view propagation driver - #22123
Open
rascani wants to merge 2 commits into
Open
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22123
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New FailuresAs of commit 8596697 with merge base e831b3e ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the propagation algorithm itself to backends/transforms, leaving the TOSA
configuration behind in the Arm backend. The Arm file is now 107 lines: the
overrides mixin, and two subclasses that combine it with ArmPass and the shared
Up and Down passes.
The split is possible because the extension points landed first. The algorithm
asks whether a node is transparent, whether an elementwise op carries extra
non-layout inputs, whether a user blocks crossing, whether to propagate at all,
which region-cancellation engine to fuse with, and which duplicate users must
not be collapsed. Arm answers all six; the shared defaults are neutral, so a
backend that answers none still gets a working mover.
Class names are unchanged on the Arm side, so arm_pass_manager and the existing
tests are untouched. Method resolution puts the TOSA overrides ahead of the
shared implementation and ArmPass last, which is what the previous single-file
arrangement did implicitly.
Cortex-M can now use this instead of growing its own fixed-point loop, which is
the point of the exercise: on the shared 36-case matrix this driver reaches 82
permutes where that loop stalls at 156.
No behaviour change: the Arm pass suite produces a failure set identical to
merge base, name for name.
Authored with Claude Code.