Skip to content

Transforms: share the permute/view propagation driver - #22123

Open
rascani wants to merge 2 commits into
gh/rascani/26/headfrom
gh/rascani/27/head
Open

Transforms: share the permute/view propagation driver#22123
rascani wants to merge 2 commits into
gh/rascani/26/headfrom
gh/rascani/27/head

Conversation

@rascani

@rascani rascani commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Move the propagation algorithm itself to backends/transforms, leaving the TOSA
configuration behind in the Arm backend. The Arm file is now 107 lines: the
overrides mixin, and two subclasses that combine it with ArmPass and the shared
Up and Down passes.

The split is possible because the extension points landed first. The algorithm
asks whether a node is transparent, whether an elementwise op carries extra
non-layout inputs, whether a user blocks crossing, whether to propagate at all,
which region-cancellation engine to fuse with, and which duplicate users must
not be collapsed. Arm answers all six; the shared defaults are neutral, so a
backend that answers none still gets a working mover.

Class names are unchanged on the Arm side, so arm_pass_manager and the existing
tests are untouched. Method resolution puts the TOSA overrides ahead of the
shared implementation and ArmPass last, which is what the previous single-file
arrangement did implicitly.

Cortex-M can now use this instead of growing its own fixed-point loop, which is
the point of the exercise: on the shared 36-case matrix this driver reaches 82
permutes where that loop stalls at 156.

No behaviour change: the Arm pass suite produces a failure set identical to
merge base, name for name.

Authored with Claude Code.

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22123

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures

As of commit 8596697 with merge base e831b3e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant