Bump CI version #1416
Bump CI version #1416
Conversation
Bump CMake to 3.31.9 and 4.2.0 Add ubuntu-24.04 for test. Signed-off-by: Ariel Xiong <[email protected]>
| os: [ubuntu-22.04, ubuntu-24.04-arm, macos-latest] | ||
| cmake_version: ["3.20.0", "4.1.2"] | ||
| os: [ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, macos-latest] | ||
| cmake_version: ["3.31.9", "4.2.0"] |
There was a problem hiding this comment.
Our CMakeLists.txt files declare a minimum CMake version of 3.20, so that version should be maintained for testing.
There was a problem hiding this comment.
Just considering if we should bump cmake min version too
There was a problem hiding this comment.
Unless we have a strong reason to bump the minimum CMake version (a new feature we want to use that isn't supported, etc.), we should avoid increasing the minimum version. All that would do is remove support for the system CMake packaged in older distros without any benefit.
| matrix: | ||
| os: [ubuntu-22.04, ubuntu-24.04-arm, macos-latest] | ||
| cmake_version: ["3.20.0", "4.1.2"] | ||
| os: [ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, macos-latest] |
There was a problem hiding this comment.
I'm not sure there is much benefit to running CI on both Ubuntu 22.04 and Ubuntu 24.04 other than maybe different compiler versions?
There was a problem hiding this comment.
gcc and some lib like gmp
There was a problem hiding this comment.
Fair point, but we do already have ubuntu-24.04-arm. I think it's ok to test the combinations with a pairwise testing approach rather than exhaustively. Doesn't cost us any more I guess but think of the environment! :-D
If we run into an issue that this would have caught we can reevaluate.
|
@Arielfoever seems like the only part of this PR that we want to proceed with is bumping the default latest CMake version. Can you update this accordingly (drop the change to the minimum CMake version and the addition of Ubuntu-24.04)? |
3 participants
Bump CMake to 3.31.9 and 4.2.0
Add ubuntu-24.04 for test.